Skip to content

Add helm diff upgrade --dry-run to show install diff without cluster access #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2020
Merged

Add helm diff upgrade --dry-run to show install diff without cluster access #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/helm3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (d *diffCmd) template(isUpgrade bool) ([]byte, error) {
// Let's simulate that in helm-diff.
// See https://medium.com/@kcatstack/understand-helm-upgrade-flags-reset-values-reuse-values-6e58ac8f127e
shouldDefaultReusingValues := isUpgrade && len(d.values) == 0 && len(d.stringValues) == 0 && len(d.valueFiles) == 0 && len(d.fileValues) == 0
if (d.reuseValues || shouldDefaultReusingValues) && !d.resetValues {
if (d.reuseValues || shouldDefaultReusingValues) && !d.resetValues && !d.dryRun {
tmpfile, err := ioutil.TempFile("", "existing-values")
if err != nil {
return nil, err
Expand All @@ -126,7 +126,7 @@ func (d *diffCmd) template(isUpgrade bool) ([]byte, error) {
flags = append(flags, "--set-file", fileValue)
}

if !d.disableValidation {
if !d.disableValidation && !d.dryRun {
flags = append(flags, "--validate")
}

Expand Down
13 changes: 11 additions & 2 deletions cmd/upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ type diffCmd struct {
devel bool
disableValidation bool
disableOpenAPIValidation bool
dryRun bool
namespace string // namespace to assume the release to be installed into. Defaults to the current kube config namespace.
valueFiles valueFiles
values []string
Expand Down Expand Up @@ -113,6 +114,7 @@ func newChartCommand() *cobra.Command {
f.IntVarP(&diff.outputContext, "context", "C", -1, "output NUM lines of context around changes")
f.BoolVar(&diff.disableValidation, "disable-validation", false, "disables rendered templates validation against the Kubernetes cluster you are currently pointing to. This is the same validation performed on an install")
f.BoolVar(&diff.disableOpenAPIValidation, "disable-openapi-validation", false, "disables rendered templates validation against the Kubernetes OpenAPI Schema")
f.BoolVar(&diff.dryRun, "dry-run", false, "disables cluster access and show diff as if it was install. Implies --install, --reset-values, and --disable-validation")
f.StringVar(&diff.postRenderer, "post-renderer", "", "the path to an executable to be used for post rendering. If it exists in $PATH, the binary will be used, otherwise it will try to look for the executable at the given path")
f.StringVar(&diff.output, "output", "diff", "Possible values: diff, simple, json, template. When set to \"template\", use the env var HELM_DIFF_TPL to specify the template.")
if !isHelm3() {
Expand All @@ -132,7 +134,14 @@ func (d *diffCmd) runHelm3() error {
if err := compatibleHelm3Version(); err != nil {
return err
}
releaseManifest, err := getRelease(d.release, d.namespace)

var releaseManifest []byte

var err error

if !d.dryRun {
releaseManifest, err = getRelease(d.release, d.namespace)
}

var newInstall bool
if err != nil && strings.Contains(err.Error(), "release: not found") {
Expand All @@ -155,7 +164,7 @@ func (d *diffCmd) runHelm3() error {
}

currentSpecs := make(map[string]*manifest.MappingResult)
if !newInstall {
if !newInstall && !d.dryRun {
if !d.noHooks {
hooks, err := getHooks(d.release, d.namespace)
if err != nil {
Expand Down