Failed to install helm-diff

[0x234]

helm plugin install https://github.com/databus23/helm-diff --version master      

Failed to install helm-diff
	For support, go to https://github.com/databus23/helm-diff.
Error: plugin install hook for "diff" exited with error

[0x234]

For anybody following along: use helm plugin install https://github.com/databus23/helm-diff

@dackroyd is correct

[dackroyd]

The listed command doesn't work if Helm 3 is installed

[dackroyd]

HELM_PLUGIN_DIR only ends up set if Helm v2 is in use: https://github.com/databus23/helm-diff/pull/206/files#diff-4de5a19daf48eac2f11c321271177a1bR12

When fetching tag versions, the git repo being checked is blank string, rather than the plugin dir: https://github.com/databus23/helm-diff/pull/206/files#diff-4de5a19daf48eac2f11c321271177a1bR74

[0x234]

helm plugin install https://github.com/databus23/helm-diff --version e186caafe744378a6059f9b70084b49daf196ede allows an installation before the regression was introduced

[mumoshu]

Thanks everyone.

Turns out my take on this thread was wrong: https://github.com/databus23/helm-diff/pull/206/files#r421447182

So, : ${BAR:=bar} does set BAR to bar. We need to remove if [ "$HELM_MAJOR_VERSION" = "Client: v2" ]; then and fi in L11 and L13.

Could anyone submit a pull request for that?

[mumoshu]

I've confirmed that it works for me now. Could anyone double-check?