Some manifests are not diffed

[semekh]

Test Scenario

Clone the repository at: https://github.com/SeMeKh/helm-diff-reproduce-diff-issue

1. helm3 install myrelease mychart
2. helm3 diff upgrade myrelease mychart --set "service.port=81"
   The diff command shows no changes, although there should be.
3. helm3 upgrade myrelease mychart --set "service.port=81"
   The service port changes indeed.

[databus23]

Could you please provide the output of the following commands:
helm3 version
helm3 plugin list

Thanks.

[semekh]

$  helm3 version
version.BuildInfo{Version:"v3.0.0-rc.1", GitCommit:"ee77ae3d40fd599445ebd99b8fc04e2c86ca366c", GitTreeState:"clean", GoVersion:"go1.13.3"}
$ helm3 plugin list
NAME    VERSION         DESCRIPTION                           
diff    3.0.0-rc.6      Preview helm upgrade changes as a diff

[databus23]

Ok that's reasonable and should work.
Could you provide the output of helm3 diff upgrade myrelease mychart --set "service.port=81 --debug?

[semekh]

Executing helm3 get manifest myrelease --namespace default
Executing helm3 template myrelease mychart --namespace default --set service.port=81
Executing helm3 get hooks myrelease --namespace default

And result of executing the 2nd command is:

---
# Source: mychart/templates/service.yaml
apiVersion: v1
kind: Service
metadata:
  name: myrelease-mychart
spec:
  type: ClusterIP
  ports:
    - port: 81
      targetPort: http
      protocol: TCP
      name: http

[databus23]

Ok but can you run the diff command with —debug

[databus23]

Sorry accidentally closed this issue

[semekh]

The first block is the output of running helm3 diff upgrade myrelease mychart --set "service.port=81" --debug
Am I missing something?

[databus23]

I‘m confused. The output should be very verbose with helm and plugin binary spewing out a lot of debug info. Specifically the diff plugin should print out the helm commands it executed under the hood.

[databus23]

Ah ok sorry my bad I understand now

[semekh]

I might add that I can diff lots of other charts successfully. I'm starting to suspect that only the first manifests' diff is ignored e.g. if I have a chart containing multiple manifests, and I apply a change, only the first manifest does not show up as changed.

[databus23]

Oh, that is interesting.
I'm starting to suspect that something changed with helm3 that make this not valid anymore:
https://github.com/databus23/helm-diff/blob/master/manifest/parse.go#L91

[databus23]

I think I got it. The problem is the leading newline in this seperator: https://github.com/databus23/helm-diff/blob/master/manifest/parse.go#L18

Let me chew on it...

[databus23]

I believe the reported issue is closed by c583d07.

I also just released 3.0.0-rc.7 which should address this bug.

Thanks for reporting this issue.