Skip to content

Conversation

@devoncarew
Copy link
Contributor

tweak how we send progress events:

  • messages generally end in ellipses, in order to indicate that a task is ongoing
  • finished events don't send messages
  • progressId fields generally aren't needed. This is only used by flutter_tools to help clients call out hot reload and hot restart progress event

@grouma

@jakemac53
Copy link
Contributor

@DanTup does this line up with what you expect on the vscode side of things as well?

@DanTup
Copy link
Contributor

DanTup commented Apr 19, 2019

Yeah, this looks fine. I think we already handle null progress IDs from Flutter (I'm not sure VS Code actually uses them at all, I think it just assumes they're always sequential so doesn't track them individually), and since finished:true just hides the progress indicator, the message isn't used.

If there any issues, I'll review the IntelliJ code and make sure VS Code is behaving the same. Thanks for the ping!

@devoncarew devoncarew merged commit 6268703 into master Apr 19, 2019
@grouma grouma deleted the tweak_progress_events branch May 28, 2019 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants