From c5e1e4f5edebe7f164689b8776524916c4c7b581 Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Thu, 13 Mar 2025 16:38:43 -0700 Subject: [PATCH 1/2] [package:markdown] update package:web references in the example --- pkgs/markdown/CHANGELOG.md | 1 + pkgs/markdown/example/app.dart | 18 ++++++++++-------- pkgs/markdown/pubspec.yaml | 2 +- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/pkgs/markdown/CHANGELOG.md b/pkgs/markdown/CHANGELOG.md index 4b20f92f9..9fea9d2ac 100644 --- a/pkgs/markdown/CHANGELOG.md +++ b/pkgs/markdown/CHANGELOG.md @@ -2,6 +2,7 @@ * Update the README link to the markdown playground (https://dart-lang.github.io/tools). +* Update `package:web` API references in the example. ## 7.3.0 diff --git a/pkgs/markdown/example/app.dart b/pkgs/markdown/example/app.dart index 14b8f1937..51d560f19 100644 --- a/pkgs/markdown/example/app.dart +++ b/pkgs/markdown/example/app.dart @@ -40,10 +40,10 @@ final extensionSets = { }; void main() { - versionSpan.text = 'v${md.version}'; + versionSpan.textContent = 'v${md.version}'; markdownInput.onKeyUp.listen(_renderMarkdown); - final savedMarkdown = window.localStorage['markdown']; + final savedMarkdown = window.localStorage.getItem('markdown'); if (savedMarkdown != null && savedMarkdown.isNotEmpty && @@ -57,7 +57,7 @@ void main() { // GitHub is the default extension set. gfmRadio.attributes.getNamedItem('checked')?.value = ''; - gfmRadio.querySelector('.glyph')!.text = 'radio_button_checked'; + gfmRadio.querySelector('.glyph')!.textContent = 'radio_button_checked'; extensionSet = extensionSets[gfmRadio.id]; _renderMarkdown(); @@ -82,7 +82,7 @@ void _renderMarkdown([Event? event]) { if (event != null) { // Not simulated typing. Store it. - window.localStorage['markdown'] = markdown; + window.localStorage.setItem('markdown', markdown); } } @@ -110,19 +110,21 @@ void _switchFlavor(Event e) { if (target.attributes.getNamedItem('checked') == null) { if (basicRadio != target) { basicRadio.attributes.safeRemove('checked'); - basicRadio.querySelector('.glyph')!.text = 'radio_button_unchecked'; + basicRadio.querySelector('.glyph')!.textContent = + 'radio_button_unchecked'; } if (commonmarkRadio != target) { commonmarkRadio.attributes.safeRemove('checked'); - commonmarkRadio.querySelector('.glyph')!.text = 'radio_button_unchecked'; + commonmarkRadio.querySelector('.glyph')!.textContent = + 'radio_button_unchecked'; } if (gfmRadio != target) { gfmRadio.attributes.safeRemove('checked'); - gfmRadio.querySelector('.glyph')!.text = 'radio_button_unchecked'; + gfmRadio.querySelector('.glyph')!.textContent = 'radio_button_unchecked'; } target.attributes.getNamedItem('checked')?.value = ''; - target.querySelector('.glyph')!.text = 'radio_button_checked'; + target.querySelector('.glyph')!.textContent = 'radio_button_checked'; extensionSet = extensionSets[target.id]; _renderMarkdown(); } diff --git a/pkgs/markdown/pubspec.yaml b/pkgs/markdown/pubspec.yaml index 3a713831b..e534628a0 100644 --- a/pkgs/markdown/pubspec.yaml +++ b/pkgs/markdown/pubspec.yaml @@ -31,5 +31,5 @@ dev_dependencies: pool: ^1.5.1 tar: ^1.0.3 test: ^1.16.0 - web: '>=0.4.2 <2.0.0' + web: ^1.0.0 yaml: ^3.0.0 From f5d0c0f33d166f9fc06cd483cf902ef64abac087 Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Thu, 13 Mar 2025 16:43:06 -0700 Subject: [PATCH 2/2] require 3.4 --- .github/workflows/markdown.yaml | 2 +- pkgs/markdown/CHANGELOG.md | 1 + pkgs/markdown/pubspec.yaml | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/markdown.yaml b/.github/workflows/markdown.yaml index e96448b52..4c8be1fee 100644 --- a/.github/workflows/markdown.yaml +++ b/.github/workflows/markdown.yaml @@ -70,7 +70,7 @@ jobs: matrix: # Add macos-latest and/or windows-latest if relevant for this package. os: [ubuntu-latest] - sdk: [3.2, dev] + sdk: [3.4, dev] steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 - uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c diff --git a/pkgs/markdown/CHANGELOG.md b/pkgs/markdown/CHANGELOG.md index 9fea9d2ac..b67e9751a 100644 --- a/pkgs/markdown/CHANGELOG.md +++ b/pkgs/markdown/CHANGELOG.md @@ -3,6 +3,7 @@ * Update the README link to the markdown playground (https://dart-lang.github.io/tools). * Update `package:web` API references in the example. +* Require Dart `^3.4.0`. ## 7.3.0 diff --git a/pkgs/markdown/pubspec.yaml b/pkgs/markdown/pubspec.yaml index e534628a0..a7a5bdaab 100644 --- a/pkgs/markdown/pubspec.yaml +++ b/pkgs/markdown/pubspec.yaml @@ -12,7 +12,7 @@ executables: markdown: environment: - sdk: ^3.2.0 + sdk: ^3.4.0 dependencies: args: ^2.0.0