Add missing Compiler Selectors heading #2548
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ❗
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
natebosch
added a commit
that referenced
this pull request
Oct 16, 2025
A "platform" in the test runner's use encompasses more detail than might be expected. Add a sentence in the description of platform selectors to note that it can cover details about how the code is compiled. Replaces #2548
Member
|
What do you think about #2550 ? |
natebosch
reviewed
Oct 16, 2025
| * `posix`: Whether the test is running on a POSIX operating system. This is | ||
| equivalent to `!windows`. | ||
|
|
||
| ### Compiler Selectors |
Member
There was a problem hiding this comment.
Hmm, I'm not sure it makes sense to add a separate header for this section, but I think we can do some rephrasing above to make it more clear how general a "platform" is. I'll take a try at a rewrite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
Compiler Selectorsheading and update the@TestOnexample to include a compiler identifier.