tearDown is not called if a test times out

[itsjoeconway]

Ran into this issue in particular when the current working directory was being manipulated in the test, and restored in tearDown.

Repro:

import 'dart:async';

import 'package:test/test.dart';

void main() {
  tearDown(() {
    print("tearDown");
  });

  test("test", () async {
    await new Future.delayed(Duration(seconds: 5));
  }, timeout: new Timeout(Duration(seconds: 1)));
}

[jakemac53]

I don't know that it is entirely clear if tearDown should or should not be called in this case.

The problem is, the test is actually still running after the timeout (until the isolate is killed at least). There isn't a trivial way to cancel async tasks that are already scheduled in Dart. We could investigate some zone crazyness here to effectively do this though?

So, given that the test is still actually running, executing tearDown may have unintended side effects or fail entirely. For instance if you are running a process in a temp dir which you clean up in tearDown, and the process is still running when you execute tearDown, then it will fail to delete the directory on windows.