[cfe+dart2js] Move annotation testing logic to front_end

Change-Id: Ic53c3d34d5c56232ac011e99972ef8f145aac6da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108602
Reviewed-by: Jens Johansen <[email protected]>

Author: johnniwinther

pkg/front_end/lib/src/testing/id.dart

@@ -17,6 +17,10 @@ enum IdKind {
 /// Id for a code point or element.
 abstract class Id {
   IdKind get kind;
+
+  /// Indicates whether the id refers to an element defined outside of the test
+  /// case itself (e.g. some tests may need to refer to properties of elements
+  /// in `dart:core`).
   bool get isGlobal;
 
   /// Display name for this id.
@@ -260,6 +264,9 @@ class ActualData<T> {
 abstract class DataRegistry<T> {
   Map<Id, ActualData<T>> get actualMap;
 
+  /// Registers [value] with [id] in [actualMap].
+  ///
+  /// Checks for duplicate data for [id].
   void registerValue(Uri uri, int offset, Id id, T value, Object object) {
     if (actualMap.containsKey(id)) {
       ActualData<T> existingData = actualMap[id];
@@ -276,7 +283,9 @@ abstract class DataRegistry<T> {
     }
   }
 
+  /// Called to report duplicate errors.
   void report(Uri uri, int offset, String message);
 
+  /// Called to raise an exception on duplicate errors.
   void fail(String message);
 }

pkg/front_end/lib/src/testing/id_extractor.dart

@@ -1,12 +1,12 @@
-// Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2019, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:kernel/ast.dart';
 import 'id.dart';
 
 /// Compute a canonical [Id] for kernel-based nodes.
-Id computeEntityId(Member node) {
+Id computeMemberId(Member node) {
   String className;
   if (node.enclosingClass != null) {
     className = node.enclosingClass.name;
@@ -34,6 +34,11 @@ abstract class DataExtractor<T> extends Visitor with DataRegistry<T> {
   @override
   final Map<Id, ActualData<T>> actualMap;
 
+  /// Implement this to compute the data corresponding to [cls].
+  ///
+  /// If `null` is returned, [cls] has no associated data.
+  T computeClassValue(Id id, Class cls);
+
   /// Implement this to compute the data corresponding to [member].
   ///
   /// If `null` is returned, [member] has no associated data.
@@ -46,8 +51,16 @@ abstract class DataExtractor<T> extends Visitor with DataRegistry<T> {
 
   DataExtractor(this.actualMap);
 
+  void computeForClass(Class cls) {
+    ClassId id = new ClassId(cls.name);
+    T value = computeClassValue(id, cls);
+    TreeNode nodeWithOffset = computeTreeNodeWithOffset(cls);
+    registerValue(nodeWithOffset?.location?.file, nodeWithOffset?.fileOffset,
+        id, value, cls);
+  }
+
   void computeForMember(Member member) {
-    MemberId id = computeEntityId(member);
+    MemberId id = computeMemberId(member);
     if (id == null) return;
     T value = computeMemberValue(id, member);
     TreeNode nodeWithOffset = computeTreeNodeWithOffset(member);
@@ -261,4 +274,16 @@ abstract class DataExtractor<T> extends Visitor with DataRegistry<T> {
     computeForNode(node, createGotoId(node));
     super.visitContinueSwitchStatement(node);
   }
+
+  @override
+  visitConstantExpression(ConstantExpression node) {
+    if (node.fileOffset == TreeNode.noOffset) {
+      // Implicit constants (for instance omitted field initializers, implicit
+      // default values) and synthetic constants (for instance in noSuchMethod
+      // forwarders) have no offset.
+    } else {
+      computeForNode(node, computeDefaultNodeId(node));
+    }
+    super.visitConstantExpression(node);
+  }
 }