Skip to content

Commit fa68d27

Browse files
committed
[infra] Add explanation to ABI test logs
Change-Id: I96ba3fe6bfd294a6b9864973e5e2e9dea20417ba Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150981 Reviewed-by: Karl Klose <[email protected]> Reviewed-by: Alexander Aprelev <[email protected]>
1 parent e601ca5 commit fa68d27

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

tools/run_abi_tests.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,11 +166,18 @@ def diffResults(results, configuration_name):
166166
def makeLog(diffs, results, logRecords, configuration_name):
167167
result = pickOne(results)
168168
logs = ["%s: %s" % (str(v), l['log']) for v, l in logRecords.items()]
169+
log = ('This test fails if there is a difference in the test results\n'
170+
'between ABI versions. The expected result is the result on the\n'
171+
'current ABI: %s\n'
172+
'These ABI versions reported a different result: %s\n\n'
173+
'These are the logs of the test runs on different ABI versions.\n'
174+
'There are no logs for versions where the test passed.\n\n%s' %
175+
(result['result'], repr(diffs), '\n\n\n'.join(logs)))
169176
return {
170177
'name': result['name'],
171178
'configuration': configuration_name,
172179
'result': result['result'],
173-
'log': '\n\n\n'.join([repr(diffs)] + logs),
180+
'log': log,
174181
}
175182

176183

0 commit comments

Comments
 (0)