Fix false negative in avoid_types_as_parameter_names (dart-archive/linter#2823)

* Fix false negative in `avoid_types_as_parameter_names`

* use visitGenericFunctionType

* Remove visitGenericFunctionType

* Merge and removed sections done for a now fixed issue.

* Lint for implicit types.

* Make tests has implicit parameter types

Author: asashour

lib/src/rules/avoid_types_as_parameter_names.dart

@@ -68,8 +68,6 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitFormalParameterList(FormalParameterList node) {
-    if (node.parent is GenericFunctionType) return;
-
     for (var parameter in node.parameters) {
       var declaredElement = parameter.declaredElement;
       var name = parameter.name;
@@ -87,7 +85,9 @@ class _Visitor extends SimpleAstVisitor<void> {
     var result = context.resolveNameInScope(name.lexeme, false, scope);
     if (result.isRequestedName) {
       var element = result.element;
-      return element is ClassElement || element is TypeAliasElement;
+      return element is ClassElement ||
+          element is TypeAliasElement ||
+          element is TypeParameterElement;
     }
     return false;
   }

test_data/rules/avoid_types_as_parameter_names.dart

@@ -45,4 +45,14 @@ m10(m1) => null; // OK
 class FieldFormalParameter {
   final int num;
   FieldFormalParameter(this.num); // OK
-}
+}
+
+void m11<X>(X) {} // LINT
+
+void m12(int Function<T>(T) g) {} // OK
+
+class C<X> {
+  C.name();
+  factory C(X) => C.name(); // LINT
+  void m(void Function(X) h) {} // OK
+}