Fix for ConflictingEditException in RemoveUnusedLocalVariable.

[email protected], [email protected]

Change-Id: I5614e83b5b7dca720b5de09a5ee7fd457a13b2e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179820
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analysis_server/lib/src/services/correction/dart/remove_unused_local_variable.dart

@@ -50,6 +50,19 @@ class RemoveUnusedLocalVariable extends CorrectionProducer {
         return;
       }
 
+      var isCovered = false;
+      for (var other in sourceRanges) {
+        if (other.covers(sourceRange)) {
+          isCovered = true;
+        } else if (other.intersects(sourceRange)) {
+          return;
+        }
+      }
+
+      if (isCovered) {
+        continue;
+      }
+
       sourceRanges.add(sourceRange);
     }
 

pkg/analysis_server/test/src/services/correction/fix/remove_unused_local_variable_test.dart

@@ -20,6 +20,21 @@ class RemoveUnusedLocalVariableTest extends FixProcessorTest {
   @override
   FixKind get kind => DartFixKind.REMOVE_UNUSED_LOCAL_VARIABLE;
 
+  Future<void> test_assignmentInAssignment() async {
+    await resolveTestCode(r'''
+main() {
+  var v = 1;
+  v = (v = 2);
+  print(0);
+}
+''');
+    await assertHasFix(r'''
+main() {
+  print(0);
+}
+''');
+  }
+
   Future<void> test_inArgumentList() async {
     await resolveTestCode(r'''
 main() {