Remove a duplication of analysis from some tests

Change-Id: Ib358b943519172afaf32ba9185ebec96c57beeda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171322
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: bwilkerson

pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart

@@ -61,10 +61,7 @@ class StatementCompletionTest extends AbstractSingleUnitTest {
   }
 
   Future<void> _computeCompletion(int offset) async {
-    // TODO(brianwilkerson) I'm fairly confident that `result` is equivalent to
-    //  `testAnalysisResult` and that we're resolving the file twice.
-    var result = await session.getResolvedUnit(testFile);
-    var context = StatementCompletionContext(result, offset);
+    var context = StatementCompletionContext(testAnalysisResult, offset);
     var processor = StatementCompletionProcessor(context);
     var completion = await processor.compute();
     change = completion.change;