Skip to content

Commit d1bd3a2

Browse files
rakudramacommit-bot@chromium.org
authored andcommitted
[gardening] Fix language_2/generic_instanceof2_test
Change-Id: Ida4afe8488a6c58ebfedde901ae293465a320714 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108741 Reviewed-by: Lasse R.H. Nielsen <[email protected]> Commit-Queue: Stephen Adams <[email protected]>
1 parent 3dcaea5 commit d1bd3a2

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

tests/language_2/generic_instanceof2_test.dart

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,13 @@ testAll() {
3838
Expect.isTrue(foo_int_num.FooString() is Foo<int, String>);
3939

4040
var foo_raw = new Foo();
41-
Expect.isTrue(foo_raw is Foo<int, num>);
42-
Expect.isTrue(foo_raw is Foo<int, String>);
41+
Expect.isTrue(foo_raw is! Foo<int, num>);
42+
Expect.isTrue(foo_raw is! Foo<int, String>);
43+
Expect.isTrue(foo_raw is Foo<dynamic, dynamic>);
4344
// foo_raw.FooString() returns a Foo<dynamic, String>
4445
Expect.isTrue(foo_raw.FooString() is! Foo<int, num>);
45-
Expect.isTrue(foo_raw.FooString() is Foo<int, String>);
46+
Expect.isTrue(foo_raw.FooString() is! Foo<int, String>);
47+
Expect.isTrue(foo_raw.FooString() is Foo<dynamic, String>);
4648

4749
var moo_int_num = new Moo<int, num>();
4850
Expect.isTrue(moo_int_num is Moo<int, num>);
@@ -52,11 +54,13 @@ testAll() {
5254
Expect.isTrue(moo_int_num.MooString() is Moo<int, String>);
5355

5456
var moo_raw = new Moo();
55-
Expect.isTrue(moo_raw is Moo<int, num>);
56-
Expect.isTrue(moo_raw is Moo<int, String>);
57+
Expect.isTrue(moo_raw is! Moo<int, num>);
58+
Expect.isTrue(moo_raw is! Moo<int, String>);
59+
Expect.isTrue(moo_raw is Moo<dynamic, dynamic>);
5760
// moo_raw.MooString() returns a Moo<dynamic, String>
5861
Expect.isTrue(moo_raw.MooString() is! Moo<int, num>);
59-
Expect.isTrue(moo_raw.MooString() is Moo<int, String>);
62+
Expect.isTrue(moo_raw.MooString() is! Moo<int, String>);
63+
Expect.isTrue(moo_raw.MooString() is Moo<dynamic, String>);
6064
}
6165

6266
main() {

tests/language_2/language_2_dart2js.status

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ function_propagation_test: RuntimeError
7474
function_subtype_inline2_test: RuntimeError
7575
generic_function_bounds_test: RuntimeError
7676
generic_function_dcall_test/01: RuntimeError
77-
generic_instanceof2_test: RuntimeError
7877
generic_is_check_test: RuntimeError
7978
generic_methods_bounds_test/02: MissingRuntimeError
8079
generic_no_such_method_dispatcher_simple_test: CompileTimeError

tests/language_2/language_2_kernel.status

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ flatten_test/12: MissingRuntimeError
5858
function_propagation_test: RuntimeError
5959
function_subtype_inline2_test: RuntimeError
6060
generic_function_bounds_test: RuntimeError
61-
generic_instanceof2_test: RuntimeError
6261
generic_is_check_test: RuntimeError
6362
generic_no_such_method_dispatcher_simple_test: CompileTimeError
6463
generic_no_such_method_dispatcher_test: CompileTimeError
@@ -618,7 +617,6 @@ flatten_test/12: MissingRuntimeError
618617
for_in_side_effects_test/01: MissingCompileTimeError
619618
function_propagation_test: RuntimeError
620619
function_subtype_inline2_test: RuntimeError
621-
generic_instanceof2_test: RuntimeError
622620
generic_is_check_test: RuntimeError
623621
generic_methods_recursive_bound_test/03: Pass
624622
generic_methods_recursive_bound_test/03: MissingRuntimeError
@@ -939,7 +937,6 @@ flatten_test/12: MissingRuntimeError
939937
for_in_side_effects_test/01: MissingCompileTimeError
940938
function_propagation_test: RuntimeError
941939
function_subtype_inline2_test: RuntimeError
942-
generic_instanceof2_test: RuntimeError
943940
generic_is_check_test: RuntimeError
944941
generic_no_such_method_dispatcher_simple_test: CompileTimeError # Issue 31533
945942
generic_no_such_method_dispatcher_test: CompileTimeError # Issue 31533

0 commit comments

Comments
 (0)