Skip to content

Commit d16c0a1

Browse files
johnniwinthercommit-bot@chromium.org
authored andcommitted
[cfe] Change supportSetLiterals default value to true
This aligns the NoneTarget with the raw output of the CFE. Change-Id: Ic3a0a3de46dac389d0ade581192e392fdaba9553 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108721 Reviewed-by: Jens Johansen <[email protected]> Commit-Queue: Johnni Winther <[email protected]>
1 parent d1fcefc commit d16c0a1

File tree

4 files changed

+4
-7
lines changed

4 files changed

+4
-7
lines changed

pkg/compiler/lib/src/kernel/dart2js_target.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,6 @@ class Dart2jsTarget extends Target {
7878
@override
7979
bool get errorOnUnexactWebIntLiterals => true;
8080

81-
@override
82-
bool get supportsSetLiterals => true;
83-
8481
@override
8582
void performModularTransformationsOnLibraries(
8683
ir.Component component,

pkg/dev_compiler/lib/src/kernel/target.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,6 @@ class DevCompilerTarget extends Target {
9191
@override
9292
bool get errorOnUnexactWebIntLiterals => true;
9393

94-
@override
95-
bool get supportsSetLiterals => true;
96-
9794
@override
9895
bool get enableNoSuchMethodForwarders => true;
9996

pkg/kernel/lib/target/targets.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ abstract class Target {
197197
/// literals are not supported by the target, they will be desugared into
198198
/// explicit `Set` creation (for non-const set literals) or wrapped map
199199
/// literals (for const set literals).
200-
bool get supportsSetLiterals => false;
200+
bool get supportsSetLiterals => true;
201201

202202
/// Builds an expression that instantiates an [Invocation] that can be passed
203203
/// to [noSuchMethod].

pkg/vm/lib/target/vm.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ class VmTarget extends Target {
4545
@override
4646
bool get enableNoSuchMethodForwarders => true;
4747

48+
@override
49+
bool get supportsSetLiterals => false;
50+
4851
@override
4952
String get name => 'vm';
5053

0 commit comments

Comments
 (0)