collection API use de-linting

pq · commit-bot@chromium.org · commit c2ff2ca16dad · 2019-07-10T22:49:10.000Z
Change-Id: I8879f48d484830ff594295b983363b7e3245f092 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108668 Commit-Queue: Phil Quitslund <pquitslund@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/analysis_server/analysis_options.yaml b/pkg/analysis_server/analysis_options.yaml
@@ -3,5 +3,7 @@ linter:
     - empty_constructor_bodies # pedantic
     - empty_statements
     - prefer_equal_for_default_values # pedantic
+    - prefer_is_empty # pedantic
+    - prefer_is_not_empty # pedantic
     - unnecessary_brace_in_string_interps
     - valid_regexps # pedantic
diff --git a/pkg/analysis_server/lib/src/computer/computer_outline.dart b/pkg/analysis_server/lib/src/computer/computer_outline.dart
@@ -463,7 +463,7 @@ class _FunctionBodyOutlinesVisitor extends RecursiveAstVisitor {
     engine.ExecutableElement executableElement = nameElement;
 
     String extractString(NodeList<Expression> arguments) {
-      if (arguments != null && arguments.length > 0) {
+      if (arguments != null && arguments.isNotEmpty) {
         Expression argument = arguments[0];
         if (argument is StringLiteral) {
           String value = argument.stringValue;
diff --git a/pkg/analysis_server/lib/src/lsp/handlers/commands/simple_edit_handler.dart b/pkg/analysis_server/lib/src/lsp/handlers/commands/simple_edit_handler.dart
@@ -29,7 +29,7 @@ abstract class SimpleEditCommandHandler
       List<SourceEdit> edits) async {
     // If there are no edits to apply, just complete the command without going
     // back to the client.
-    if (edits.length == 0) {
+    if (edits.isEmpty) {
       return success();
     }
 
diff --git a/pkg/analysis_server/lib/src/services/completion/completion_performance.dart b/pkg/analysis_server/lib/src/services/completion/completion_performance.dart
@@ -23,7 +23,7 @@ class CompletionPerformance {
   }
 
   int get elapsedInMilliseconds =>
-      operations.length > 0 ? operations.last.elapsed.inMilliseconds : 0;
+      operations.isNotEmpty ? operations.last.elapsed.inMilliseconds : 0;
 
   String get suggestionCount {
     if (notificationCount < 1) return '';
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart
@@ -41,7 +41,7 @@ bool _isAppendingToArgList(DartCompletionRequest request) {
     if (entity == node.rightParenthesis) {
       return true;
     }
-    if (node.arguments.length > 0 && node.arguments.last == entity) {
+    if (node.arguments.isNotEmpty && node.arguments.last == entity) {
       return entity is SimpleIdentifier;
     }
   }
@@ -172,7 +172,7 @@ class ArgListContributor extends DartCompletionContributor {
       ParameterElement parameter, bool appendColon, bool appendComma) {
     String name = parameter.name;
     String type = parameter.type?.displayName;
-    if (name != null && name.length > 0 && !namedArgs.contains(name)) {
+    if (name != null && name.isNotEmpty && !namedArgs.contains(name)) {
       String completion = name;
       if (appendColon) {
         completion += ': ';
@@ -220,7 +220,7 @@ class ArgListContributor extends DartCompletionContributor {
   }
 
   void _addSuggestions(Iterable<ParameterElement> parameters) {
-    if (parameters == null || parameters.length == 0) {
+    if (parameters == null || parameters.isEmpty) {
       return;
     }
     Iterable<ParameterElement> requiredParam =
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/field_formal_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/field_formal_contributor.dart
@@ -44,7 +44,7 @@ class FieldFormalContributor extends DartCompletionContributor {
         SimpleIdentifier fieldId = param.identifier;
         if (fieldId != null && fieldId != request.target.entity) {
           String fieldName = fieldId.name;
-          if (fieldName != null && fieldName.length > 0) {
+          if (fieldName != null && fieldName.isNotEmpty) {
             referencedFields.add(fieldName);
           }
         }
@@ -61,7 +61,7 @@ class FieldFormalContributor extends DartCompletionContributor {
           SimpleIdentifier fieldId = varDecl.name;
           if (fieldId != null) {
             String fieldName = fieldId.name;
-            if (fieldName != null && fieldName.length > 0) {
+            if (fieldName != null && fieldName.isNotEmpty) {
               if (!referencedFields.contains(fieldName)) {
                 CompletionSuggestion suggestion = createSuggestion(
                     fieldId.staticElement,
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/label_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/label_contributor.dart
@@ -145,7 +145,7 @@ class _LabelVisitor extends LocalDeclarationVisitor {
   CompletionSuggestion _addSuggestion(SimpleIdentifier id) {
     if (id != null) {
       String completion = id.name;
-      if (completion != null && completion.length > 0 && completion != '_') {
+      if (completion != null && completion.isNotEmpty && completion != '_') {
         CompletionSuggestion suggestion = new CompletionSuggestion(
             CompletionSuggestionKind.IDENTIFIER,
             DART_RELEVANCE_DEFAULT,
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/library_prefix_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/library_prefix_contributor.dart
@@ -33,7 +33,7 @@ class LibraryPrefixContributor extends DartCompletionContributor {
     List<CompletionSuggestion> suggestions = <CompletionSuggestion>[];
     for (ImportElement element in imports) {
       String completion = element.prefix?.name;
-      if (completion != null && completion.length > 0) {
+      if (completion != null && completion.isNotEmpty) {
         LibraryElement libElem = element.importedLibrary;
         if (libElem != null) {
           CompletionSuggestion suggestion = createSuggestion(libElem,
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart
@@ -127,7 +127,7 @@ class _Visitor extends LocalDeclarationVisitor {
       }
 
       String name = constructorDecl.name?.name;
-      if (name != null && name.length > 0) {
+      if (name != null && name.isNotEmpty) {
         completion = '$completion.$name';
       }
 
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
@@ -169,8 +169,8 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor
           createSuggestion(constructor, relevance: relevance);
       if (suggestion != null) {
         String name = suggestion.completion;
-        name = name.length > 0 ? '$className.$name' : className;
-        if (prefix != null && prefix.length > 0) {
+        name = name.isNotEmpty ? '$className.$name' : className;
+        if (prefix != null && prefix.isNotEmpty) {
           name = '$prefix.$name';
         }
         suggestion.completion = name;
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/override_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/override_contributor.dart
@@ -96,7 +96,7 @@ class OverrideContributor implements DartCompletionContributor {
         completion.startsWith(overrideAnnotation)) {
       completion = completion.substring(overrideAnnotation.length).trim();
     }
-    if (completion.length == 0) {
+    if (completion.isEmpty) {
       return null;
     }
 
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart
@@ -112,7 +112,7 @@ class _SuggestionBuilder extends GeneralizingElementVisitor {
       }
     }
     String completion = element.displayName;
-    if (completion == null || completion.length <= 0) {
+    if (completion == null || completion.isEmpty) {
       return;
     }
     CompletionSuggestion suggestion =
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart b/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart
@@ -119,14 +119,14 @@ mixin ElementSuggestionBuilder {
       }
     }
     String completion = elementCompletion ?? element.displayName;
-    if (prefix != null && prefix.length > 0) {
-      if (completion == null || completion.length <= 0) {
+    if (prefix != null && prefix.isNotEmpty) {
+      if (completion == null || completion.isEmpty) {
         completion = prefix;
       } else {
         completion = '$prefix.$completion';
       }
     }
-    if (completion == null || completion.length <= 0) {
+    if (completion == null || completion.isEmpty) {
       return null;
     }
     CompletionSuggestion suggestion = createSuggestion(element,
@@ -203,7 +203,7 @@ class LibraryElementSuggestionBuilder extends SimpleElementVisitor
       ClassElement classElem = element.enclosingElement;
       if (classElem != null) {
         String prefix = classElem.name;
-        if (prefix != null && prefix.length > 0) {
+        if (prefix != null && prefix.isNotEmpty) {
           addSuggestion(element, prefix: prefix);
         }
       }
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/utilities.dart b/pkg/analysis_server/lib/src/services/completion/dart/utilities.dart
@@ -114,7 +114,7 @@ CompletionSuggestion createLocalSuggestion(SimpleIdentifier id,
     return null;
   }
   String completion = id.name;
-  if (completion == null || completion.length <= 0 || completion == '_') {
+  if (completion == null || completion.isEmpty || completion == '_') {
     return null;
   }
   CompletionSuggestion suggestion = new CompletionSuggestion(
@@ -131,7 +131,7 @@ CompletionSuggestion createLocalSuggestion(SimpleIdentifier id,
     SimpleIdentifier classId = classDecl.name;
     if (classId != null) {
       String className = classId.name;
-      if (className != null && className.length > 0) {
+      if (className != null && className.isNotEmpty) {
         suggestion.declaringType = className;
       }
     }
diff --git a/pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart b/pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
@@ -894,7 +894,7 @@ class StatementCompletionProcessor {
 
   bool _complete_simpleEnter() {
     int offset;
-    if (!errors.isEmpty) {
+    if (errors.isNotEmpty) {
       offset = selectionOffset;
     } else {
       String indent = utils.getLinePrefix(selectionOffset);
diff --git a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart
@@ -848,7 +848,7 @@ class AssistProcessor {
         node.offset > creation.argumentList.offset ||
         creation.staticType.element != typeProvider.listType.element ||
         creation.constructorName.name != null ||
-        creation.argumentList.arguments.length > 0) {
+        creation.argumentList.arguments.isNotEmpty) {
       _coverageMarker();
       return;
     }
@@ -4299,7 +4299,7 @@ class AssistProcessor {
   /// placed inside curly braces, would lexically make the resulting literal a
   /// set literal rather than a map literal.
   bool _listHasUnambiguousElement(AstNode node) {
-    if (node is ListLiteral && node.elements.length > 0) {
+    if (node is ListLiteral && node.elements.isNotEmpty) {
       for (CollectionElement element in node.elements) {
         if (_isUnambiguousElement(element)) {
           return true;
diff --git a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
@@ -1776,14 +1776,14 @@ class FixProcessor {
 
           builder.write(targetLocation.prefix);
           builder.write(targetClassName);
-          if (!constructorName.isEmpty) {
+          if (constructorName.isNotEmpty) {
             builder.write('.');
             builder.addSimpleLinkedEdit('NAME', constructorName);
           }
           builder.write('(');
           writeParameters(true);
           builder.write(') : super');
-          if (!constructorName.isEmpty) {
+          if (constructorName.isNotEmpty) {
             builder.write('.');
             builder.addSimpleLinkedEdit('NAME', constructorName);
           }
@@ -2305,7 +2305,7 @@ class FixProcessor {
       builder.addInsertion(insertOffset, (DartEditBuilder builder) {
         builder.selectHere();
         // insert empty line before existing member
-        if (!targetClass.members.isEmpty) {
+        if (targetClass.members.isNotEmpty) {
           builder.write(eol);
         }
         // append method
@@ -4220,7 +4220,7 @@ class FixProcessor {
     StringBuffer buffer = new StringBuffer();
     buffer.write('super');
     String constructorName = constructor.displayName;
-    if (!constructorName.isEmpty) {
+    if (constructorName.isNotEmpty) {
       buffer.write('.');
       buffer.write(constructorName);
     }
diff --git a/pkg/analysis_server/lib/src/services/correction/namespace.dart b/pkg/analysis_server/lib/src/services/correction/namespace.dart
@@ -82,7 +82,7 @@ ImportElement internal_getImportElement(
       }
     }
     // no combinators => only possible candidate
-    if (importElement.combinators.length == 0) {
+    if (importElement.combinators.isEmpty) {
       return importElement;
     }
     // OK, we have candidate
diff --git a/pkg/analysis_server/lib/src/services/correction/selection_analyzer.dart b/pkg/analysis_server/lib/src/services/correction/selection_analyzer.dart
@@ -39,7 +39,7 @@ class SelectionAnalyzer extends GeneralizingAstVisitor<void> {
    * selection [SourceRange].
    */
   bool get hasSelectedNodes =>
-      _selectedNodes != null && !_selectedNodes.isEmpty;
+      _selectedNodes != null && _selectedNodes.isNotEmpty;
 
   /**
    * Returns `true` if there was no selected nodes yet.
diff --git a/pkg/analysis_server/lib/src/services/correction/sort_members.dart b/pkg/analysis_server/lib/src/services/correction/sort_members.dart
@@ -116,7 +116,7 @@ class MemberSorter {
       if (member is FieldDeclaration) {
         FieldDeclaration fieldDeclaration = member;
         List<VariableDeclaration> fields = fieldDeclaration.fields.variables;
-        if (!fields.isEmpty) {
+        if (fields.isNotEmpty) {
           kind = _MemberKind.CLASS_FIELD;
           isStatic = fieldDeclaration.isStatic;
           name = fields[0].name.name;
@@ -314,7 +314,7 @@ class MemberSorter {
         TopLevelVariableDeclaration variableDeclaration = member;
         List<VariableDeclaration> variables =
             variableDeclaration.variables.variables;
-        if (!variables.isEmpty) {
+        if (variables.isNotEmpty) {
           if (variableDeclaration.variables.isConst) {
             kind = _MemberKind.UNIT_VARIABLE_CONST;
           } else {
diff --git a/pkg/analysis_server/lib/src/services/correction/util.dart b/pkg/analysis_server/lib/src/services/correction/util.dart
@@ -711,7 +711,7 @@ class CorrectionUtils {
     // determine if empty line is required after
     int nextLineOffset = getLineNext(offset);
     String insertLine = source.substring(offset, nextLineOffset);
-    if (!insertLine.trim().isEmpty) {
+    if (insertLine.trim().isNotEmpty) {
       insertEmptyLineAfter = true;
     }
     // fill InsertDesc
diff --git a/pkg/analysis_server/lib/src/services/kythe/kythe_visitors.dart b/pkg/analysis_server/lib/src/services/kythe/kythe_visitors.dart
@@ -30,7 +30,7 @@ String _computeConstructorElementName(ConstructorElement element) {
   assert(element != null);
   var name = element.enclosingElement.name;
   var constructorName = element.name;
-  if (!constructorName.isEmpty) {
+  if (constructorName.isNotEmpty) {
     name = name + '.' + constructorName;
   }
   return name;
diff --git a/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart b/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart
@@ -219,7 +219,7 @@ class ExtractMethodRefactoringImpl extends RefactoringImpl
     _prepareExcludedNames();
     _prepareNames();
     // closure cannot have parameters
-    if (_selectionFunctionExpression != null && !_parameters.isEmpty) {
+    if (_selectionFunctionExpression != null && _parameters.isNotEmpty) {
       String message = format(
           'Cannot extract closure as method, it references {0} external variable(s).',
           _parameters.length);
@@ -510,7 +510,7 @@ class ExtractMethodRefactoringImpl extends RefactoringImpl
     }
 
     // Check selected nodes.
-    if (!selectedNodes.isEmpty) {
+    if (selectedNodes.isNotEmpty) {
       AstNode selectedNode = selectedNodes.first;
       _parentMember = getEnclosingClassOrUnitMember(selectedNode);
       // single expression selected
@@ -558,7 +558,7 @@ class ExtractMethodRefactoringImpl extends RefactoringImpl
       return false;
     }
     // has parameters
-    if (!parameters.isEmpty) {
+    if (parameters.isNotEmpty) {
       return false;
     }
     // is assignment
diff --git a/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart b/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart
@@ -388,7 +388,7 @@ class InlineMethodRefactoringImpl extends RefactoringImpl
     } else if (_methodBody is BlockFunctionBody) {
       Block body = (_methodBody as BlockFunctionBody).block;
       List<Statement> statements = body.statements;
-      if (statements.length >= 1) {
+      if (statements.isNotEmpty) {
         Statement lastStatement = statements[statements.length - 1];
         // "return" statement requires special handling
         if (lastStatement is ReturnStatement) {
@@ -399,7 +399,7 @@ class InlineMethodRefactoringImpl extends RefactoringImpl
           statements = statements.sublist(0, statements.length - 1);
         }
         // if there are statements, process them
-        if (!statements.isEmpty) {
+        if (statements.isNotEmpty) {
           SourceRange statementsRange =
               _methodUtils.getLinesRangeStatements(statements);
           _methodStatementsPart = _createSourcePart(statementsRange);
diff --git a/pkg/analysis_server/lib/src/services/search/hierarchy.dart b/pkg/analysis_server/lib/src/services/search/hierarchy.dart
@@ -160,7 +160,7 @@ Set<ClassElement> getSuperClasses(ClassElement seed) {
   List<ClassElement> queue = new List<ClassElement>();
   queue.add(seed);
   // process queue
-  while (!queue.isEmpty) {
+  while (queue.isNotEmpty) {
     ClassElement current = queue.removeLast();
     // add if not checked already
     if (!result.add(current)) {
diff --git a/pkg/analysis_server/test/completion_test_support.dart b/pkg/analysis_server/test/completion_test_support.dart
@@ -190,14 +190,14 @@ class LocationSpec {
     }
     if (!(badPoints.isEmpty && badResults.isEmpty)) {
       StringBuffer err = new StringBuffer();
-      if (!badPoints.isEmpty) {
+      if (badPoints.isNotEmpty) {
         err.write("No test location for tests:");
         for (String ch in badPoints) {
           err..write(' ')..write(ch);
         }
         err.write(' ');
       }
-      if (!badResults.isEmpty) {
+      if (badResults.isNotEmpty) {
         err.write("No results for tests:");
         for (String ch in badResults) {
           err..write(' ')..write(ch);
diff --git a/pkg/analysis_server/test/edit/postfix_completion_test.dart b/pkg/analysis_server/test/edit/postfix_completion_test.dart
@@ -69,7 +69,7 @@ main() {
 
   void _assertHasChange(String message, String expectedCode, [Function cmp]) {
     if (change.message == message) {
-      if (!change.edits.isEmpty) {
+      if (change.edits.isNotEmpty) {
         String resultCode =
             SourceEdit.applySequence(testCode, change.edits[0].edits);
         expect(resultCode, expectedCode.replaceAll('/*caret*/', ''));
diff --git a/pkg/analysis_server/test/edit/statement_completion_test.dart b/pkg/analysis_server/test/edit/statement_completion_test.dart
@@ -104,7 +104,7 @@ main() {
 
   void _assertHasChange(String message, String expectedCode, [Function cmp]) {
     if (change.message == message) {
-      if (!change.edits.isEmpty) {
+      if (change.edits.isNotEmpty) {
         String resultCode =
             SourceEdit.applySequence(testCode, change.edits[0].edits);
         expect(resultCode, expectedCode.replaceAll('/*caret*/', ''));
diff --git a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
@@ -77,7 +77,7 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
 
   void assertNoSuggestions({CompletionSuggestionKind kind = null}) {
     if (kind == null) {
-      if (suggestions.length > 0) {
+      if (suggestions.isNotEmpty) {
         failedCompletion('Expected no suggestions', suggestions);
       }
       return;
diff --git a/pkg/analysis_server/test/services/completion/postfix/postfix_completion_test.dart b/pkg/analysis_server/test/services/completion/postfix/postfix_completion_test.dart
diff --git a/pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart b/pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart
diff --git a/pkg/analysis_server/test/src/services/correction/fix/fix_processor.dart b/pkg/analysis_server/test/src/services/correction/fix/fix_processor.dart
diff --git a/pkg/analysis_server/test/stress/completion/completion.dart b/pkg/analysis_server/test/stress/completion/completion.dart
diff --git a/pkg/analysis_server/test/stress/completion/completion_runner.dart b/pkg/analysis_server/test/stress/completion/completion_runner.dart
diff --git a/pkg/analysis_server/test/stress/replay/replay.dart b/pkg/analysis_server/test/stress/replay/replay.dart
diff --git a/pkg/analysis_server/test/timing/timing_framework.dart b/pkg/analysis_server/test/timing/timing_framework.dart
diff --git a/pkg/analysis_server/tool/instrumentation/page/stats_page.dart b/pkg/analysis_server/tool/instrumentation/page/stats_page.dart
diff --git a/pkg/analysis_server/tool/spec/to_html.dart b/pkg/analysis_server/tool/spec/to_html.dart

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ abstract class SimpleEditCommandHandler`
`29`	`29`	`List<SourceEdit> edits) async {`
`30`	`30`	`// If there are no edits to apply, just complete the command without going`
`31`	`31`	`// back to the client.`
`32`		`- if (edits.length == 0) {`
	`32`	`+ if (edits.isEmpty) {`
`33`	`33`	`return success();`
`34`	`34`	`}`
`35`	`35`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ class CompletionPerformance {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`int get elapsedInMilliseconds =>`
`26`		`- operations.length > 0 ? operations.last.elapsed.inMilliseconds : 0;`
	`26`	`+ operations.isNotEmpty ? operations.last.elapsed.inMilliseconds : 0;`
`27`	`27`
`28`	`28`	`String get suggestionCount {`
`29`	`29`	`if (notificationCount < 1) return '';`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ bool _isAppendingToArgList(DartCompletionRequest request) {`
`41`	`41`	`if (entity == node.rightParenthesis) {`
`42`	`42`	`return true;`
`43`	`43`	`}`
`44`		`- if (node.arguments.length > 0 && node.arguments.last == entity) {`
	`44`	`+ if (node.arguments.isNotEmpty && node.arguments.last == entity) {`
`45`	`45`	`return entity is SimpleIdentifier;`
`46`	`46`	`}`
`47`	`47`	`}`
`@@ -172,7 +172,7 @@ class ArgListContributor extends DartCompletionContributor {`
`172`	`172`	`ParameterElement parameter, bool appendColon, bool appendComma) {`
`173`	`173`	`String name = parameter.name;`
`174`	`174`	`String type = parameter.type?.displayName;`
`175`		`- if (name != null && name.length > 0 && !namedArgs.contains(name)) {`
	`175`	`+ if (name != null && name.isNotEmpty && !namedArgs.contains(name)) {`
`176`	`176`	`String completion = name;`
`177`	`177`	`if (appendColon) {`
`178`	`178`	`completion += ': ';`
`@@ -220,7 +220,7 @@ class ArgListContributor extends DartCompletionContributor {`
`220`	`220`	`}`
`221`	`221`
`222`	`222`	`void _addSuggestions(Iterable<ParameterElement> parameters) {`
`223`		`- if (parameters == null \|\| parameters.length == 0) {`
	`223`	`+ if (parameters == null \|\| parameters.isEmpty) {`
`224`	`224`	`return;`
`225`	`225`	`}`
`226`	`226`	`Iterable<ParameterElement> requiredParam =`
Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ class _Visitor extends LocalDeclarationVisitor {`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`String name = constructorDecl.name?.name;`
`130`		`- if (name != null && name.length > 0) {`
	`130`	`+ if (name != null && name.isNotEmpty) {`
`131`	`131`	`completion = '$completion.$name';`
`132`	`132`	`}`
`133`	`133`