Elements. Stop using ConstructorElementMixin in constants evaluation.

Change-Id: I54e22bd9a0068ffa8de5a7ded932131327f672fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/437105
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Paul Berry <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/constant/compute.dart

@@ -67,8 +67,9 @@ class _ConstantWalker extends graph.DependencyWalker<_ConstantNode> {
     var constantsInCycle = scc.map((node) => node.constant);
     for (var node in scc) {
       var constant = node.constant;
-      if (constant is ConstructorFragmentImpl) {
-        constant.isCycleFree = false;
+      if (constant is ConstructorElementImpl) {
+        // TODO(scheglov): move the flag to the element
+        constant.firstFragment.isCycleFree = false;
       }
       _getEvaluationEngine(node).generateCycleError(constantsInCycle, constant);
     }

pkg/analyzer/lib/src/dart/constant/constant_verifier.dart

@@ -33,7 +33,6 @@ import 'package:analyzer/src/diagnostic/diagnostic_factory.dart';
 import 'package:analyzer/src/error/codes.dart';
 import 'package:analyzer/src/generated/exhaustiveness.dart';
 import 'package:analyzer/src/utilities/extensions/ast.dart';
-import 'package:analyzer/src/utilities/extensions/element.dart';
 
 /// Instances of the class `ConstantVerifier` traverse an AST structure looking
 /// for additional errors and warnings not covered by the parser and resolver.
@@ -213,11 +212,7 @@ class ConstantVerifier extends RecursiveAstVisitor<void> {
     if (node.isConst) {
       var constructor = node.constructorName.element;
       if (constructor is ConstructorElementMixin2) {
-        _validateConstructorInvocation(
-          node,
-          constructor.asElement,
-          node.argumentList,
-        );
+        _validateConstructorInvocation(node, constructor, node.argumentList);
       }
     } else {
       super.visitDotShorthandConstructorInvocation(node);
@@ -288,7 +283,7 @@ class ConstantVerifier extends RecursiveAstVisitor<void> {
         CompileTimeErrorCode.CONST_WITH_TYPE_PARAMETERS,
       );
 
-      var constructor = node.constructorName.element?.asElement;
+      var constructor = node.constructorName.element;
       if (constructor != null) {
         _validateConstructorInvocation(node, constructor, node.argumentList);
       }
@@ -916,7 +911,7 @@ class ConstantVerifier extends RecursiveAstVisitor<void> {
   /// arguments are constant expressions.
   void _validateConstructorInvocation(
     AstNode node,
-    ConstructorElementMixin constructor,
+    ConstructorElementMixin2 constructor,
     ArgumentList argumentList,
   ) {
     var constantVisitor = ConstantVisitor(