Skip to content

Commit bd3b329

Browse files
bwilkersoncommit-bot@chromium.org
authored andcommitted
Correct an abbreviation
Change-Id: I7424cd587c87f1256237de1cf913b9b0b31104f2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151341 Reviewed-by: Jaime Wren <[email protected]> Commit-Queue: Brian Wilkerson <[email protected]>
1 parent badc772 commit bd3b329

File tree

3 files changed

+51
-51
lines changed

3 files changed

+51
-51
lines changed

pkg/analysis_server/test/tool/completion_metrics/metrics_util_test.dart

Lines changed: 41 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -78,56 +78,56 @@ void main() {
7878

7979
group('MeanReciprocalRankComputer', () {
8080
test('empty', () {
81-
var mrrc = MeanReciprocalRankComputer('');
82-
expect(mrrc.count, equals(0));
83-
expect(mrrc.mrr, equals(0));
81+
var computer = MeanReciprocalRankComputer('');
82+
expect(computer.count, equals(0));
83+
expect(computer.mrr, equals(0));
8484
});
8585

8686
test('clear', () {
87-
var mrrc = MeanReciprocalRankComputer('');
88-
mrrc.addRank(2);
89-
expect(mrrc.count, equals(1));
90-
expect(mrrc.mrr, equals(1 / 2));
91-
expect(mrrc.mrr_5, equals(1 / 2));
92-
93-
mrrc.clear();
94-
expect(mrrc.count, equals(0));
95-
expect(mrrc.mrr, equals(0));
96-
expect(mrrc.mrr_5, equals(0));
87+
var computer = MeanReciprocalRankComputer('');
88+
computer.addRank(2);
89+
expect(computer.count, equals(1));
90+
expect(computer.mrr, equals(1 / 2));
91+
expect(computer.mrr_5, equals(1 / 2));
92+
93+
computer.clear();
94+
expect(computer.count, equals(0));
95+
expect(computer.mrr, equals(0));
96+
expect(computer.mrr_5, equals(0));
9797
});
9898

99-
test('mmr- single value', () {
100-
var mrrc = MeanReciprocalRankComputer('');
101-
mrrc.addRank(3);
102-
mrrc.addRank(3);
103-
mrrc.addRank(3);
104-
mrrc.addRank(3);
105-
mrrc.addRank(3);
106-
expect(mrrc.count, equals(5));
107-
expect(mrrc.mrr, doubleEquals(1 / 3));
108-
expect(mrrc.mrr_5, doubleEquals(1 / 3));
99+
test('mrr- single value', () {
100+
var computer = MeanReciprocalRankComputer('');
101+
computer.addRank(3);
102+
computer.addRank(3);
103+
computer.addRank(3);
104+
computer.addRank(3);
105+
computer.addRank(3);
106+
expect(computer.count, equals(5));
107+
expect(computer.mrr, doubleEquals(1 / 3));
108+
expect(computer.mrr_5, doubleEquals(1 / 3));
109109
});
110110

111-
test('mmr- example', () {
112-
var mrrc = MeanReciprocalRankComputer('');
113-
mrrc.addRank(3);
114-
mrrc.addRank(2);
115-
mrrc.addRank(1);
116-
expect(mrrc.count, equals(3));
117-
expect(mrrc.mrr, doubleEquals(11 / 18));
118-
expect(mrrc.mrr_5, doubleEquals(11 / 18));
111+
test('mrr- example', () {
112+
var computer = MeanReciprocalRankComputer('');
113+
computer.addRank(3);
114+
computer.addRank(2);
115+
computer.addRank(1);
116+
expect(computer.count, equals(3));
117+
expect(computer.mrr, doubleEquals(11 / 18));
118+
expect(computer.mrr_5, doubleEquals(11 / 18));
119119
});
120120

121-
test('mmr- max rank', () {
122-
var mrrc = MeanReciprocalRankComputer('');
123-
mrrc.addRank(6);
124-
mrrc.addRank(5);
125-
mrrc.addRank(4);
126-
mrrc.addRank(3);
127-
mrrc.addRank(2);
128-
mrrc.addRank(1);
129-
expect(mrrc.count, equals(6));
130-
expect(mrrc.mrr, greaterThan(mrrc.mrr_5));
121+
test('mrr- max rank', () {
122+
var computer = MeanReciprocalRankComputer('');
123+
computer.addRank(6);
124+
computer.addRank(5);
125+
computer.addRank(4);
126+
computer.addRank(3);
127+
computer.addRank(2);
128+
computer.addRank(1);
129+
expect(computer.count, equals(6));
130+
expect(computer.mrr, greaterThan(computer.mrr_5));
131131
});
132132
});
133133

pkg/analysis_server/tool/completion_metrics/completion_metrics.dart

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ class CompletionMetrics {
211211
MeanReciprocalRankComputer topLevelMrrComputer =
212212
MeanReciprocalRankComputer('non-type member completions');
213213

214-
Map<String, MeanReciprocalRankComputer> locationMmrComputers = {};
214+
Map<String, MeanReciprocalRankComputer> locationMrrComputers = {};
215215

216216
ArithmeticMeanComputer charsBeforeTop =
217217
ArithmeticMeanComputer('chars_before_top');
@@ -259,7 +259,7 @@ class CompletionMetrics {
259259
/// as well as the longest sets of results to compute.
260260
void recordCompletionResult(CompletionResult result) {
261261
_recordTime(result);
262-
_recordMmr(result);
262+
_recordMrr(result);
263263
_recordWorstResult(result);
264264
_recordSlowestResult(result);
265265
_recordMissingInformation(result);
@@ -279,8 +279,8 @@ class CompletionMetrics {
279279
}
280280
}
281281

282-
/// Record the MMR for the [result].
283-
void _recordMmr(CompletionResult result) {
282+
/// Record the MRR for the [result].
283+
void _recordMrr(CompletionResult result) {
284284
var rank = result.place.rank;
285285
// Record globally.
286286
successfulMrrComputer.addRank(rank);
@@ -299,7 +299,7 @@ class CompletionMetrics {
299299
// Record by completion location.
300300
var location = result.completionLocation;
301301
if (location != null) {
302-
var computer = locationMmrComputers.putIfAbsent(
302+
var computer = locationMrrComputers.putIfAbsent(
303303
location, () => MeanReciprocalRankComputer(location));
304304
computer.addRank(rank);
305305
}
@@ -517,7 +517,7 @@ class CompletionMetricsComputer {
517517

518518
if (verbose) {
519519
var lines = <LocationTableLine>[];
520-
for (var entry in metrics.locationMmrComputers.entries) {
520+
for (var entry in metrics.locationMrrComputers.entries) {
521521
var count = entry.value.count;
522522
var mrr = (1 / entry.value.mrr);
523523
var mrr_5 = (1 / entry.value.mrr_5);
@@ -531,7 +531,7 @@ class CompletionMetricsComputer {
531531
}
532532
lines.sort((first, second) => second.product.compareTo(first.product));
533533
var table = <List<String>>[];
534-
table.add(['Location', 'Product', 'Count', 'Mmr', 'Mmr_5']);
534+
table.add(['Location', 'Product', 'Count', 'Mrr', 'Mrr_5']);
535535
for (var line in lines) {
536536
var location = line.label;
537537
var product = line.product.truncate().toString();
@@ -1036,7 +1036,7 @@ class CompletionResult {
10361036
}
10371037
}
10381038

1039-
/// The data to be printed on a single line in the table of mmr values per
1039+
/// The data to be printed on a single line in the table of mrr values per
10401040
/// completion location.
10411041
class LocationTableLine {
10421042
final String label;

pkg/analysis_server/tool/completion_metrics/metrics_util.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,10 @@ class MeanReciprocalRankComputer {
132132

133133
void printMean() {
134134
print('Mean Reciprocal Rank \'$name\' (total = $count)');
135-
print('mmr = ${mrr.toStringAsFixed(6)} '
135+
print('mrr = ${mrr.toStringAsFixed(6)} '
136136
'(inverse = ${(1 / mrr).toStringAsFixed(3)})');
137137

138-
print('mmr_5 = ${mrr_5.toStringAsFixed(6)} '
138+
print('mrr_5 = ${mrr_5.toStringAsFixed(6)} '
139139
'(inverse = ${(1 / mrr_5).toStringAsFixed(3)})');
140140
}
141141
}

0 commit comments

Comments
 (0)