[stable][ddc] Add new name for ddc compiler

* The new compiler name "ddc" will be used for all configurations
  in an upcoming change.
* Aliases "dartdevc" and "dartdevk" will be removed in the future.

Issue: #51481
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/280862
Change-Id: Icd81c63bff57911816a4e187a40e4a4012eead85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284543
Reviewed-by: Alexander Thomas <[email protected]>

Author: nshahan

pkg/expect/lib/config.dart

@@ -26,7 +26,8 @@ bool get isDart2WasmConfiguration =>
 
 bool get isDdcConfiguration =>
     _configuration.compiler == Compiler.dartdevk ||
-    _configuration.compiler == Compiler.dartdevc;
+    _configuration.compiler == Compiler.dartdevc ||
+    _configuration.compiler == Compiler.ddc;
 
 bool get isVmJitConfiguration => _configuration.compiler == Compiler.dartk;
 

pkg/smith/lib/configuration.dart

@@ -639,6 +639,7 @@ class Compiler extends NamedEnum {
   static const dart2wasm = Compiler._('dart2wasm');
   static const dartdevc = Compiler._('dartdevc');
   static const dartdevk = Compiler._('dartdevk');
+  static const ddc = Compiler._('ddc');
   static const appJitk = Compiler._('app_jitk');
   static const dartk = Compiler._('dartk');
   static const dartkp = Compiler._('dartkp');
@@ -653,6 +654,7 @@ class Compiler extends NamedEnum {
     dart2wasm,
     dartdevc,
     dartdevk,
+    ddc,
     appJitk,
     dartk,
     dartkp,
@@ -693,6 +695,7 @@ class Compiler extends NamedEnum {
 
       case Compiler.dartdevc:
       case Compiler.dartdevk:
+      case Compiler.ddc:
         return const [
           Runtime.none,
           Runtime.d8,
@@ -734,6 +737,7 @@ class Compiler extends NamedEnum {
         return Runtime.d8;
       case Compiler.dartdevc:
       case Compiler.dartdevk:
+      case Compiler.ddc:
         return Runtime.chrome;
       case Compiler.dart2analyzer:
         return Runtime.none;
@@ -757,6 +761,7 @@ class Compiler extends NamedEnum {
       case Compiler.dart2wasm:
       case Compiler.dartdevc:
       case Compiler.dartdevk:
+      case Compiler.ddc:
       case Compiler.fasta:
         return Mode.release;
 

pkg/smith/test/configuration_test.dart

@@ -354,8 +354,8 @@ void main() {
     });
 
     group("visualCompare()", () {
-      var a = Configuration("dartdevc", Architecture.ia32, Compiler.dartdevc,
-          Mode.debug, Runtime.chrome, System.android,
+      var a = Configuration("ddc", Architecture.ia32, Compiler.ddc, Mode.debug,
+          Runtime.chrome, System.android,
           builderTag: "a tag",
           vmOptions: ["vm a1", "vm a2"],
           dart2jsOptions: ["dart2js a1", "dart2js a2"],
@@ -392,10 +392,10 @@ void main() {
 
       test("everything different", () {
         expect(a.visualCompare(b), equals("""
-dartdevc
+ddc
 dart2js
 architecture: ia32 x64
-   compiler: dartdevc dart2js
+   compiler: ddc dart2js
    mode: debug release
    runtime: chrome d8
    system: android fuchsia
@@ -423,10 +423,10 @@ architecture: ia32 x64
 
       test("everything the same", () {
         expect(a.visualCompare(a), equals("""
-dartdevc
-dartdevc
+ddc
+ddc
 architecture: ia32 ia32
-   compiler: dartdevc dartdevc
+   compiler: ddc ddc
    mode: debug debug
    runtime: chrome chrome
    system: android android

pkg/test_runner/lib/src/browser.dart

@@ -129,18 +129,18 @@ bool _invalidVariableName(String keyword, {bool strictMode = true}) {
   return false;
 }
 
-/// Generates the HTML template file needed to load and run a dartdevc test in
+/// Generates the HTML template file needed to load and run a ddc test in
 /// the browser.
 ///
 /// [testName] is the short name of the test without any subdirectory path
 /// or extension, like "math_test". [testNameAlias] is the alias of the
 /// test variable used for import/export (usually relative to its module root).
 /// [testJSDir] is the relative path to the build directory where the
-/// dartdevc-generated JS file is stored. [nonNullAsserts] enables non-null
+/// ddc-generated JS file is stored. [nonNullAsserts] enables non-null
 /// assertions for non-nullable method parameters when running with weak null
 /// safety. [weakNullSafetyErrors] enables null safety type violations to throw
 /// when running in weak mode.
-String dartdevcHtml(
+String ddcHtml(
     String testName,
     String testNameAlias,
     String testJSDir,

pkg/test_runner/lib/src/build_configurations.dart

@@ -84,6 +84,7 @@ List<String> _selectBuildTargets(Configuration inner) {
     Compiler.appJitk: ['runtime'],
     Compiler.fasta: ['create_sdk', 'dartdevc_test', 'kernel_platform_files'],
     Compiler.dartdevk: ['dartdevc_test'],
+    Compiler.ddc: ['dartdevc_test'],
     Compiler.dart2js: ['create_sdk'],
     Compiler.dart2analyzer: ['create_sdk', 'utils/dartanalyzer'],
     Compiler.specParser: <String>[],
@@ -96,7 +97,8 @@ List<String> _selectBuildTargets(Configuration inner) {
     result.add('gen_snapshot');
   }
 
-  if (compiler == Compiler.dartdevk && !inner.useSdk) {
+  if ((compiler == Compiler.dartdevk || compiler == Compiler.ddc) &&
+      !inner.useSdk) {
     result
       ..remove('dartdevc_test')
       ..add('dartdevc_test_local');

pkg/test_runner/lib/src/command_output.dart

@@ -1576,6 +1576,7 @@ mixin _StaticErrorOutput on CommandOutput {
       Compiler.dart2wasm: ErrorSource.web,
       Compiler.dartdevc: ErrorSource.web,
       Compiler.dartdevk: ErrorSource.web,
+      Compiler.ddc: ErrorSource.web,
       Compiler.fasta: ErrorSource.cfe
     }[testCase.configuration.compiler]!;
 

pkg/test_runner/lib/src/compiler_configuration.dart

@@ -87,9 +87,8 @@ abstract class CompilerConfiguration {
         return Dart2WasmCompilerConfiguration(configuration);
 
       case Compiler.dartdevc:
-        return DevCompilerConfiguration(configuration);
-
       case Compiler.dartdevk:
+      case Compiler.ddc:
         return DevCompilerConfiguration(configuration);
 
       case Compiler.appJitk:
@@ -583,16 +582,17 @@ class Dart2WasmCompilerConfiguration extends CompilerConfiguration {
   }
 }
 
-/// Configuration for `dartdevc` and `dartdevk` (DDC with Kernel)
+/// Configuration for "dartdevc", "dartdevk", and "ddc".
+// TODO(nshahan): Cleanup mulitple aliases for the compiler.
 class DevCompilerConfiguration extends CompilerConfiguration {
   DevCompilerConfiguration(TestConfiguration configuration)
       : super._subclass(configuration);
 
   String computeCompilerPath() {
-    // The compiler is a Dart program and not an executable itself, so the
-    // command to spawn as a subprocess is a Dart VM. Internally the
-    // [DevCompilerCompilationCommand] will prepend the snapshot or Dart library
-    // entrypoint that is executed by the VM.
+    // DDC is a Dart program and not an executable itself, so the command to
+    // spawn as a subprocess is a Dart VM.
+    // Internally the [DevCompilerCompilationCommand] will prepend the snapshot
+    // or Dart library entrypoint that is executed by the VM.
     // This will change once we update the DDC to use AOT instead of a snapshot.
     var dir = _useSdk ? '${_configuration.buildDirectory}/dart-sdk' : 'sdk';
     return '$dir/bin/dart$executableExtension';

pkg/test_runner/lib/src/configuration.dart

@@ -197,6 +197,7 @@ class TestConfiguration {
       Compiler.appJitk,
       Compiler.dartdevc,
       Compiler.dartdevk,
+      Compiler.ddc,
       Compiler.dartk,
       Compiler.dartkp,
       Compiler.fasta,

pkg/test_runner/lib/src/options.dart

@@ -76,8 +76,9 @@ class OptionsParser {
 dart2js:              Compile to JavaScript using dart2js.
 dart2analyzer:        Perform static analysis on Dart code using the analyzer.
 compare_analyzer_cfe: Compare analyzer and common front end representations.
-dartdevc:             Compile to JavaScript using dartdevc.
-dartdevk:             Compile to JavaScript using dartdevc (same as dartdevc).
+ddc:                  Compile to JavaScript using dartdevc.
+dartdevc:             Compile to JavaScript using dartdevc (same as ddc).
+dartdevk:             Compile to JavaScript using dartdevc (same as ddc).
 app_jitk:             Compile the Dart code into Kernel and then into an app
                       snapshot.
 dartk:                Compile the Dart code into Kernel before running test.

pkg/test_runner/lib/src/process_queue.dart

@@ -571,6 +571,7 @@ class CommandExecutorImpl implements CommandExecutor {
         (command.displayName == 'dart2js' ||
             command.displayName == 'dartdevc' ||
             command.displayName == 'dartdevk' ||
+            command.displayName == 'ddc' ||
             command.displayName == 'fasta') &&
         globalConfiguration.batch) {
       return _getBatchRunner(command.displayName)