Skip to content

Commit 97e8837

Browse files
eernstgcommit-bot@chromium.org
authored andcommitted
Reorganize language/nonfunction_type_aliases/mixed/aliased_cyclic*
This test failed because it had a test outcome expectation comment in a library which is not the entry point (cf. #44990). This CL changes the test such that said comment is located in the entry point. The trade-off is that this test now has a "reverse" import: A library with null safety enabled imports a legacy library (but, apparently, this does not cause the test to fail). PS: This means that we don't have a test that will go green when #44990 is resolved. Change-Id: Ie94bff22ce75bd662752c5814917e141fafc72ed Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191365 Reviewed-by: Leaf Petersen <[email protected]> Commit-Queue: Erik Ernst <[email protected]>
1 parent ce0a926 commit 97e8837

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

tests/language/nonfunction_type_aliases/mixed/aliased_cyclic_superclass_error_lib.dart

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
typedef T = C;
5+
import 'aliased_cyclic_superclass_error_test.dart';
66

7-
class C extends T {}
8-
// ^
9-
// [analyzer] unspecified
10-
// [cfe] unspecified
7+
typedef T = C;

tests/language/nonfunction_type_aliases/mixed/aliased_cyclic_superclass_error_test.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,9 @@
1111

1212
import 'aliased_cyclic_superclass_error_lib.dart';
1313

14+
class C extends T {}
15+
// ^
16+
// [analyzer] unspecified
17+
// [cfe] unspecified
18+
1419
main() => C();

0 commit comments

Comments
 (0)