Fix comment references in shared exhaustiveness logic.

Fix bracketed references in doc comments that previously pointed to
nowhere, in the shared exhaustiveness logic
(pkg/_fe_analyzer_shared/lib/src/exhaustiveness/...).

This is part of a larger effort to clean up _fe_analyzer_shared to the
point where the `comment_references` lint can be enabled.

Change-Id: I743cf6537316ba14ffbb90e9d93fb67c451bb308
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/375220
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Paul Berry <[email protected]>

Author: stereotype441

pkg/_fe_analyzer_shared/lib/src/exhaustiveness/exhaustive.dart

@@ -278,7 +278,7 @@ class _Checker {
   /// [singleSpace] doesn't care about that property, so inserts a default
   /// [Space] that matches all values for the property. If the [type] doesn't
   /// know about the property, the static type of the property is read from
-  /// [extensionPropertyTypes].
+  /// [Key].
   ///
   /// In other words, this unpacks a set of properties so that the main
   /// algorithm can add them to the worklist.

pkg/_fe_analyzer_shared/lib/src/exhaustiveness/path.dart

@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+/// @docImport 'space.dart';
+library;
+
 import 'key.dart';
 
 /// A path that describes location of a [SingleSpace] from the root of

pkg/_fe_analyzer_shared/lib/src/exhaustiveness/shared.dart

@@ -139,7 +139,7 @@ class ExhaustivenessCache<
   /// Cache for [SealedClassInfo] for sealed classes.
   Map<Class, SealedClassInfo<Type, Class>> _sealedClassInfo = {};
 
-  /// Cache for [UniqueStaticType]s.
+  /// Cache for unique [StaticType]s.
   Map<Object, StaticType> _uniqueTypeMap = {};
 
   /// Cache for the [StaticType] for `bool`.
@@ -458,8 +458,8 @@ mixin SpaceCreator<Pattern extends Object, Type extends Object> {
     return new Space(path, staticType, properties: properties);
   }
 
-  /// Creates the [Space] at [path] for a record pattern of the required [type],
-  /// [positionalFields], and [namedFields].
+  /// Creates the [Space] at [path] for a record pattern of the required
+  /// [recordType], [positionalFields], and [namedFields].
   Space createRecordSpace(Path path, StaticType contextType, Type recordType,
       List<Pattern> positionalFields, Map<String, Pattern> namedFields) {
     StaticType staticType =

pkg/_fe_analyzer_shared/lib/src/exhaustiveness/test_helper.dart

@@ -30,7 +30,7 @@ String spacesToText(Space space) {
   return text;
 }
 
-/// Returns a textual representation for [properties] used for testing.
+/// Returns a textual representation for [fieldsOfInterest] used for testing.
 String fieldsToText(StaticType type, ObjectPropertyLookup objectFieldLookup,
     Set<Key> fieldsOfInterest) {
   List<Key> sortedNames = fieldsOfInterest.toList()..sort();
@@ -64,7 +64,7 @@ String fieldsToText(StaticType type, ObjectPropertyLookup objectFieldLookup,
 /// Returns a textual representation for [type] used for testing.
 String staticTypeToText(StaticType type) => type.toString();
 
-/// Returns a textual representation of the subtypes of [type] used for testing.
+/// Returns a textual representation of [types] used for testing.
 String? typesToText(Iterable<StaticType> types) {
   if (types.isEmpty) return null;
   // TODO(johnniwinther): Sort types.

pkg/_fe_analyzer_shared/lib/src/exhaustiveness/types/enum.dart

@@ -73,7 +73,7 @@ class EnumInfo<Type extends Object, EnumClass extends Object,
 }
 
 /// [StaticType] for an instantiation of an enum that support access to the
-/// enum values that populate its type through the [subtypes] property.
+/// enum values that populate its type through the [getSubtypes] getter.
 class EnumStaticType<Type extends Object, EnumElement extends Object>
     extends TypeBasedStaticType<Type> {
   final EnumInfo<Type, Object, EnumElement, Object> _enumInfo;

pkg/_fe_analyzer_shared/lib/src/exhaustiveness/witness.dart

@@ -81,7 +81,7 @@ class Witness {
   String toString() => _witness.toString();
 }
 
-/// Helper class used to turn a list of [Predicates] into a string.
+/// Helper class used to turn a list of [Predicate]s into a string.
 class PropertyWitness {
   StaticType staticType = StaticType.nullableObject;
   StaticType valueType = StaticType.nullableObject;