[build/win] Copy dart.lib only if dart binaries were built with exported symbols.

aam · commit-bot@chromium.org · commit 7d7c1298e2ca · 2020-06-18T02:07:19.000Z
Flutter dart sdk is built without exported symbols, so no .lib is created. Addresses flutter/flutter#59687. Change-Id: Ia79bbb3b0b17377c417ed03fd7737000773bd18b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151660 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
diff --git a/sdk/BUILD.gn b/sdk/BUILD.gn
@@ -410,7 +410,7 @@ if (target_os != current_os && target_os == "fuchsia") {
     deps = [ "../runtime/bin:dart" ]
     dart_out = get_label_info("../runtime/bin:dart", "root_out_dir")
     sources = [ "$dart_out/${dart_stripped_binary}${executable_suffix}" ]
-    if (is_win) {
+    if (is_win && dart_lib_export_symbols) {
       sources += [ "$dart_out/dart.lib" ]
     }
     outputs = [ "$root_out_dir/dart-sdk/bin/{{source_file_part}}" ]

Original file line number	Diff line number	Diff line change
`@@ -410,7 +410,7 @@ if (target_os != current_os && target_os == "fuchsia") {`
`410`	`410`	`deps = [ "../runtime/bin:dart" ]`
`411`	`411`	`dart_out = get_label_info("../runtime/bin:dart", "root_out_dir")`
`412`	`412`	`sources = [ "$dart_out/${dart_stripped_binary}${executable_suffix}" ]`
`413`		`- if (is_win) {`
	`413`	`+ if (is_win && dart_lib_export_symbols) {`
`414`	`414`	`sources += [ "$dart_out/dart.lib" ]`
`415`	`415`	`}`
`416`	`416`	`outputs = [ "$root_out_dir/dart-sdk/bin/{{source_file_part}}" ]`