[vm] Simplify RemoveRedefinitions.

Instead of having identical cases for every instruction that implements
RedefinedValue, just have one generic piece of code.

Change-Id: If3f4905a578eb345ae3d740d1f539d346c6223af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150985
Reviewed-by: Vyacheslav Egorov <[email protected]>
Commit-Queue: Aske Simon Christensen <[email protected]>

Author: askeksa

runtime/vm/compiler/backend/flow_graph.cc

@@ -1669,21 +1669,12 @@ void FlowGraph::RemoveRedefinitions(bool keep_checks) {
         instr_it.RemoveCurrentFromGraph();
       } else if (keep_checks) {
         continue;
-      } else if (auto check = instruction->AsCheckArrayBound()) {
-        check->ReplaceUsesWith(check->index()->definition());
-        check->ClearSSATempIndex();
-      } else if (auto check = instruction->AsGenericCheckBound()) {
-        check->ReplaceUsesWith(check->index()->definition());
-        check->ClearSSATempIndex();
-      } else if (auto check = instruction->AsCheckNull()) {
-        check->ReplaceUsesWith(check->value()->definition());
-        check->ClearSSATempIndex();
-      } else if (auto check = instruction->AsAssertAssignable()) {
-        check->ReplaceUsesWith(check->value()->definition());
-        check->ClearSSATempIndex();
-      } else if (auto check = instruction->AsAssertBoolean()) {
-        check->ReplaceUsesWith(check->value()->definition());
-        check->ClearSSATempIndex();
+      } else if (auto def = instruction->AsDefinition()) {
+        Value* value = def->RedefinedValue();
+        if (value != nullptr) {
+          def->ReplaceUsesWith(value->definition());
+          def->ClearSSATempIndex();
+        }
       }
     }
   }