Skip to content

Commit 68e1708

Browse files
sgrekhovathomas
authored andcommitted
[co19] Enable Subtyping tests
* Skip tests that use type aliases on analyzer configurations. * Shard co19 test more on VM AOT builder (to avoid shard timeouts). Change-Id: I5834091e91f229242329ee9e7456ca822d18c0b5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151223 Reviewed-by: Alexander Thomas <[email protected]>
1 parent 294a2cf commit 68e1708

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

tests/co19/co19-co19.status

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ LanguageFeatures/Simple-bounds/dynamic/type-aliases/*: Skip # Not migrated to NN
101101
LanguageFeatures/Simple-bounds/static/*: Skip # Not migrated to NNBD
102102
LanguageFeatures/Simple-bounds/static/type-aliases/*: Skip # Not migrated to NNBD
103103
LanguageFeatures/Spread-collections/*: Skip # Not migrated to NNBD
104-
LanguageFeatures/Subtyping/*: Skip # Not migrated to NNBD
105104
LanguageFeatures/Super-bounded-types/*: Skip # Not migrated to NNBD
106105
LanguageFeatures/Super-mixins/*: Skip # Not migrated to NNBD
107106
LanguageFeatures/Triple-Shift/*: Skip # Not migrated to NNBD
@@ -309,6 +308,11 @@ LibTest/typed_data/Uint8ClampedList/*: Skip # Not migrated to NNBD
309308
LibTest/typed_data/Uint8List/*: Skip # Not migrated to NNBD
310309
Utils/tests/Expect/*: Skip # Not migrated to NNBD
311310

311+
[ $compiler == dart2analyzer ]
312+
LanguageFeatures/Subtyping/static/tests/left_bottom_A01_t02: Skip # Type aliases are not supported by analyzer
313+
LanguageFeatures/Subtyping/static/tests/left_bottom_A01_t04: Skip # Type aliases are not supported by analyzer
314+
LanguageFeatures/Subtyping/static/tests/left_bottom_A01_t06: Skip # Type aliases are not supported by analyzer
315+
312316
[ $compiler != fasta ]
313317
Language/Classes/Abstract_Instance_Members/inherited_t13: Skip # github.com/dart-lang/language/issues/115
314318
Language/Classes/Abstract_Instance_Members/inherited_t14: Skip # github.com/dart-lang/language/issues/115

tools/bots/test_matrix.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1376,7 +1376,7 @@
13761376
"co19"
13771377
],
13781378
"fileset": "vm-kernel",
1379-
"shards": 1
1379+
"shards": 2
13801380
},
13811381
{
13821382
"name": "co19 nnbd tests in strong mode",
@@ -1385,7 +1385,7 @@
13851385
"co19"
13861386
],
13871387
"fileset": "vm-kernel",
1388-
"shards": 1
1388+
"shards": 2
13891389
},
13901390
{
13911391
"name": "vm nnbd tests in weak mode with asserts",

0 commit comments

Comments
 (0)