Version 2.10.0-85.0.dev

Merge commit 'd27556656fba7b43d44b1bdc10d2635a34102fbe' into 'dev'

Author: Dart CI

CHANGELOG.md

@@ -8,6 +8,10 @@
     to cancel outgoing HTTP requests and stop following IO operations.
 *   A validation check is added to `path` of class `Cookie`. Having characters
     ranging from 0x00 to 0x1f and 0x3b (";") will lead to a `FormatException`.
+*   The `HttpClient` and `HttpServer` clasess now have a 1 MiB limit for the
+    total size of the HTTP headers when parsing a request or response, instead
+    of the former 8 KiB limit for each header name and value. This limit cannot
+    be configured at this time.
 
 #### `dart:typed_data`
 

pkg/_fe_analyzer_shared/pubspec.yaml

@@ -1,5 +1,5 @@
 name: _fe_analyzer_shared
-version: 8.0.0
+version: 9.0.0
 description: Logic that is shared between the front_end and analyzer packages.
 homepage: https://github.com/dart-lang/sdk/tree/master/pkg/_fe_analyzer_shared
 

pkg/analysis_server/lib/src/services/correction/bulk_fix_processor.dart

@@ -19,6 +19,7 @@ import 'package:analysis_server/src/services/correction/dart/convert_to_contains
 import 'package:analysis_server/src/services/correction/dart/convert_to_generic_function_syntax.dart';
 import 'package:analysis_server/src/services/correction/dart/convert_to_if_null.dart';
 import 'package:analysis_server/src/services/correction/dart/convert_to_int_literal.dart';
+import 'package:analysis_server/src/services/correction/dart/convert_to_null_aware.dart';
 import 'package:analysis_server/src/services/correction/dart/convert_to_where_type.dart';
 import 'package:analysis_server/src/services/correction/dart/create_method.dart';
 import 'package:analysis_server/src/services/correction/dart/make_final.dart';
@@ -99,6 +100,7 @@ class BulkFixProcessor {
     LintNames.prefer_is_empty: ReplaceWithIsEmpty.newInstance,
     LintNames.prefer_is_not_empty: UesIsNotEmpty.newInstance,
     LintNames.prefer_iterable_whereType: ConvertToWhereType.newInstance,
+    LintNames.prefer_null_aware_operators: ConvertToNullAware.newInstance,
     LintNames.prefer_single_quotes: ConvertToSingleQuotes.newInstance,
     LintNames.prefer_spread_collections: ConvertAddAllToSpread.newInstance,
     LintNames.slash_for_doc_comments: ConvertDocumentationIntoLine.newInstance,

pkg/analysis_server/lib/src/services/correction/dart/convert_quotes.dart

@@ -39,14 +39,17 @@ abstract class ConvertQuotes extends CorrectionProducer {
           });
         }
       }
-    } else if (node is InterpolationString) {
-      StringInterpolation parent = node.parent;
-      if (_fromDouble ? !parent.isSingleQuoted : parent.isSingleQuoted) {
-        var newQuote = parent.isMultiline
+    } else if (node is InterpolationString || node is StringInterpolation) {
+      StringInterpolation stringNode =
+          node is StringInterpolation ? node : node.parent;
+      if (_fromDouble
+          ? !stringNode.isSingleQuoted
+          : stringNode.isSingleQuoted) {
+        var newQuote = stringNode.isMultiline
             ? (_fromDouble ? "'''" : '"""')
             : (_fromDouble ? "'" : '"');
-        var quoteLength = parent.isMultiline ? 3 : 1;
-        var elements = parent.elements;
+        var quoteLength = stringNode.isMultiline ? 3 : 1;
+        var elements = stringNode.elements;
         for (var i = 0; i < elements.length; i++) {
           var element = elements[i];
           if (element is InterpolationString) {
@@ -58,10 +61,11 @@ abstract class ConvertQuotes extends CorrectionProducer {
         }
         await builder.addDartFileEdit(file, (builder) {
           builder.addSimpleReplacement(
-              SourceRange(parent.offset + (parent.isRaw ? 1 : 0), quoteLength),
+              SourceRange(
+                  stringNode.offset + (stringNode.isRaw ? 1 : 0), quoteLength),
               newQuote);
           builder.addSimpleReplacement(
-              SourceRange(parent.end - quoteLength, quoteLength), newQuote);
+              SourceRange(stringNode.end - quoteLength, quoteLength), newQuote);
         });
       }
     }

pkg/analysis_server/test/src/services/correction/fix/bulk/convert_to_null_aware_test.dart

@@ -0,0 +1,37 @@
+// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:analysis_server/src/services/linter/lint_names.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
+
+import 'bulk_fix_processor.dart';
+
+void main() {
+  defineReflectiveSuite(() {
+    defineReflectiveTests(ConvertToNullAwareTest);
+  });
+}
+
+@reflectiveTest
+class ConvertToNullAwareTest extends BulkFixProcessorTest {
+  @override
+  String get lintCode => LintNames.prefer_null_aware_operators;
+
+  Future<void> test_singleFile() async {
+    await resolveTestUnit('''
+abstract class A {
+  int m();
+}
+int f(A a) => null == a ? null : a.m();
+int g(A a) => a == null ? null : a.m();
+''');
+    await assertHasFix('''
+abstract class A {
+  int m();
+}
+int f(A a) => a?.m();
+int g(A a) => a?.m();
+''');
+  }
+}

pkg/analysis_server/test/src/services/correction/fix/bulk/test_all.dart

@@ -16,6 +16,7 @@ import 'convert_to_generic_function_syntax_test.dart'
 import 'convert_to_if_element_test.dart' as convert_to_if_element;
 import 'convert_to_if_null_test.dart' as convert_to_if_null;
 import 'convert_to_int_literal_test.dart' as convert_to_int_literal;
+import 'convert_to_null_aware_test.dart' as convert_to_null_aware;
 import 'convert_to_single_quoted_strings_test.dart'
     as convert_to_single_quoted_strings;
 import 'convert_to_spread_test.dart' as convert_to_spread;
@@ -60,6 +61,7 @@ void main() {
     convert_to_if_element.main();
     convert_to_if_null.main();
     convert_to_int_literal.main();
+    convert_to_null_aware.main();
     convert_to_single_quoted_strings.main();
     convert_to_spread.main();
     convert_to_where_type.main();

pkg/analysis_server/test/src/services/correction/fix/convert_to_single_quoted_string_test.dart

@@ -23,6 +23,23 @@ class ConvertToSingleQuotedStringTest extends FixProcessorLintTest {
   @override
   String get lintCode => LintNames.prefer_single_quotes;
 
+  Future<void> test_one_interpolation() async {
+    await resolveTestUnit(r'''
+main() {
+  var b = 'b';
+  var c = 'c';
+  print("a $b-${c} d");
+}
+''');
+    await assertHasFix(r'''
+main() {
+  var b = 'b';
+  var c = 'c';
+  print('a $b-${c} d');
+}
+''');
+  }
+
   /// More coverage in the `convert_to_single_quoted_string_test.dart` assist test.
   Future<void> test_one_simple() async {
     await resolveTestUnit('''