prefer “exclude” language for excluded entities

See for example:

* https://9to5google.com/2020/06/12/google-android-chrome-blacklist-blocklist-more-inclusive/
* https://thenextweb.com/dd/2020/06/15/github-plans-to-replace-racially-insensitive-terms-like-master-and-whitelist/


Change-Id: I51fe56bb7a09c5cc3280119e2c121aac86e44f8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151303
Reviewed-by: Ben Konyi <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

runtime/tools/dartfuzz/gen_api_table.dart

@@ -609,7 +609,7 @@ void addToTable(String ret, String name, List<String> proto,
   }
   // Avoid the exit function and other functions that give false divergences.
   // Note: to prevent certain constructors from being emitted, update the
-  // blacklist in `shouldFilterConstructor` in gen_type_table.dart and
+  // exclude list in `shouldFilterConstructor` in gen_type_table.dart and
   // regenerate the type table.
   if (name == 'exit' ||
       name == 'pid' ||

runtime/tools/dartfuzz/gen_type_table.dart

@@ -866,11 +866,11 @@ void filterOperators(Set<InterfaceType> allTypes) {
   }
 }
 
-// Filters methods based on a manually maintained blacklist.
+// Filters methods based on a manually maintained exclude list.
 //
-// Blacklisted methods should be associated with an issue number so they can be
+// Excluded methods should be associated with an issue number so they can be
 // re-enabled after the issue is resolved.
-bool isBlacklistedMethod(InterfaceType tp, MethodElement method) {
+bool isExcludedMethod(InterfaceType tp, MethodElement method) {
   // TODO(bkonyi): Enable operator / for these types after we resolve
   // https://github.com/dart-lang/sdk/issues/39890
   if (((tp.displayName == 'Float32x4') && (method.name == '/')) ||
@@ -888,8 +888,8 @@ bool isBlacklistedMethod(InterfaceType tp, MethodElement method) {
 // Does not recurse into interfaces and superclasses of tp.
 void getOperatorsForTyp(String typName, InterfaceType tp, fromLiteral) {
   for (MethodElement method in tp.methods) {
-    // If the method is manually blacklisted, skip it.
-    if (isBlacklistedMethod(tp, method)) continue;
+    // If the method is manually excluded, skip it.
+    if (isExcludedMethod(tp, method)) continue;
 
     // Detect whether tp can be parsed from a literal (dartfuzz.dart can
     // already handle that).
@@ -1035,7 +1035,7 @@ bool shouldFilterConstructor(InterfaceType tp, ConstructorElement cons) {
   if (cons.name.startsWith('_')) {
     return true;
   }
-  // Constructor blacklist
+  // Constructor exclude list
   // TODO(bkonyi): Enable Float32x4.fromInt32x4Bits after we resolve
   // https://github.com/dart-lang/sdk/issues/39890
   if ((tp.displayName == 'Float32x4') && (cons.name == 'fromInt32x4Bits')) {