fix use_super_parameters false positive w/ field formal params (dart-archive/linter#3293)

* fix `use_super_parameters` false positive w/ field formal params

* + super formals

Author: pq

lib/src/rules/use_super_parameters.dart

@@ -172,6 +172,8 @@ class _Visitor extends SimpleAstVisitor {
       bool match = false;
       for (var i = 0; i < constructorParams.length && !match; ++i) {
         var constructorParam = constructorParams[i];
+        if (constructorParam is FieldFormalParameter) continue;
+        if (constructorParam is SuperFormalParameter) continue;
         var constructorElement = constructorParam.declaredElement;
         if (constructorElement == null) continue;
         if (referencedParameters.contains(constructorElement)) continue;

test/rules/use_super_parameters_test.dart

@@ -22,6 +22,19 @@ class UseSuperParametersTest extends LintRuleTest {
   @override
   String get lintRule => 'use_super_parameters';
 
+  test_functionTypedFormalParameter() async {
+    await assertDiagnostics(r'''
+class A {
+  A(int f(int i));
+}
+class B extends A {
+  B(int f(int i)) : super(f);
+}
+''', [
+      lint('use_super_parameters', 53, 1),
+    ]);
+  }
+
   test_named() async {
     await assertDiagnostics(r'''
 class A {
@@ -48,6 +61,19 @@ class C extends B {
 ''');
   }
 
+  test_no_lint_invalid_fieldFormalParameter() async {
+    await assertNoDiagnostics(r'''
+class A {
+  A(int x);
+}
+class B extends A {
+  B(int x) : super(x) {
+    print(x);
+  }
+}
+''');
+  }
+
   test_no_lint_named_noSuperInvocation() async {
     await assertNoDiagnostics(r'''
 class A {
@@ -133,12 +159,12 @@ class B extends A {
   test_no_lint_referencedInBody_positional() async {
     await assertNoDiagnostics(r'''
 class A {
-  A(int x);
+  int x;
+  A(this.x);
 }
 class B extends A {
-  B(int x) : super(x) {
-    print(x);
-  }
+  int y;
+  B(this.y) : super(y);
 }
 ''');
   }