Deprecate ClassElement.hasReferenceToSuper

Change-Id: Ie94d8e2b0be6ccb30c7ca59c80da2832cfed3689
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151168
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analysis_server/lib/src/status/element_writer.dart

@@ -39,7 +39,6 @@ class ElementWriter extends GeneralizingElementVisitor with TreeWriter {
     properties['nameOffset'] = element.nameOffset;
     if (element is ClassElement) {
       properties['hasNonFinalField'] = element.hasNonFinalField;
-      properties['hasReferenceToSuper'] = element.hasReferenceToSuper;
       properties['hasStaticMember'] = element.hasStaticMember;
       properties['interfaces'] = element.interfaces;
       properties['isAbstract'] = element.isAbstract;

pkg/analyzer/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.39.11-dev
+* Deprecated `ClassElement.hasReferenceToSuper`.
+  It was used internally, should not be part of API.
+
 ## 0.39.10
 * Restored the default constructor in internal `SummaryBuilder`,
   and the `featureSet` named parameter in `build`, for `build_resolvers`

pkg/analyzer/lib/dart/element/element.dart

@@ -82,6 +82,7 @@ abstract class ClassElement
   /// hence cannot be used as a mixin), or `false` if this element represents a
   /// mixin, even if the mixin has a reference to `super`, because it is allowed
   /// to be used as a mixin.
+  @Deprecated('It was used internally, should not be part of API')
   bool get hasReferenceToSuper;
 
   /// Return `true` if this class declares a static member.

pkg/analyzer/lib/src/dart/element/element.dart

@@ -685,10 +685,12 @@ class ClassElementImpl extends AbstractClassElementImpl
     return definingClass != null && !definingClass.isDartCoreObject;
   }
 
+  @Deprecated('It was used internally, should not be part of API')
   @override
   bool get hasReferenceToSuper => hasModifier(Modifier.REFERENCES_SUPER);
 
   /// Set whether this class references 'super'.
+  /// TODO(scheglov) Remove it.
   set hasReferenceToSuper(bool isReferencedSuper) {
     setModifier(Modifier.REFERENCES_SUPER, isReferencedSuper);
   }
@@ -782,9 +784,6 @@ class ClassElementImpl extends AbstractClassElementImpl
 
   @override
   bool get isValidMixin {
-    if (hasReferenceToSuper) {
-      return false;
-    }
     if (!supertype.isDartCoreObject) {
       return false;
     }
@@ -3402,6 +3401,7 @@ class EnumElementImpl extends AbstractClassElementImpl {
   @override
   bool get hasNonFinalField => false;
 
+  @Deprecated('It was used internally, should not be part of API')
   @override
   bool get hasReferenceToSuper => false;
 

pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart

@@ -85,7 +85,6 @@ class ResolutionVisitor extends RecursiveAstVisitor<void> {
 
   /// The flag specifying if currently visited class references 'super'
   /// expression.
-  /// TODO(scheglov) put into summary
   bool _hasReferenceToSuper = false;
 
   factory ResolutionVisitor({

pkg/analyzer/test/generated/simple_resolver_test.dart

@@ -652,6 +652,7 @@ void main() {
     );
   }
 
+  @Deprecated('It was used internally, should not be part of API')
   test_hasReferenceToSuper() async {
     await assertNoErrorsInCode(r'''
 class A {}
@@ -860,7 +861,7 @@ class C = Object with A;''');
     expect(a.isValidMixin, isTrue);
   }
 
-  test_isValidMixin_super() async {
+  test_isValidMixin_super_toString() async {
     await assertNoErrorsInCode(r'''
 class A {
   toString() {
@@ -871,7 +872,7 @@ class C = Object with A;''');
     verifyTestResolved();
 
     var a = findElement.class_('A');
-    expect(a.isValidMixin, isFalse);
+    expect(a.isValidMixin, isTrue);
   }
 
   test_isValidMixin_valid() async {