Avoid divisive terms

Based on guidance in https://developers.google.com/style/w

Related to #42247

Change-Id: If40c8e39bb35f1f7dfad9cb977c7a494a2cc3bd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150626
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Michael Thomsen <[email protected]>

Author: mit-mit

pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

@@ -277,10 +277,10 @@ class ProgramBuilder {
   void _initializeSoftDeferredMap() {
     var allocatedClassesPath = _options.experimentalAllocationsPath;
     if (allocatedClassesPath != null) {
-      // TODO(29574): the following blacklist is ad-hoc and potentially
+      // TODO(29574): the following denylist is ad-hoc and potentially
       // incomplete. We need to mark all classes as black listed, that are
       // used without code going through the class' constructor.
-      var blackList = [
+      var denylist = [
         'dart:_interceptors',
         'dart:html',
         'dart:typed_data_implementation',
@@ -329,7 +329,7 @@ class ProgramBuilder {
           var key = "${element.library.canonicalUri}:${element.name}";
           if (allocatedClassesKeys.contains(key) ||
               _nativeData.isJsInteropClass(element) ||
-              blackList.contains(element.library.canonicalUri.toString())) {
+              denylist.contains(element.library.canonicalUri.toString())) {
             collect(element);
           }
         }

pkg/front_end/lib/src/fasta/source/source_loader.dart

@@ -663,9 +663,9 @@ class SourceLoader extends Loader {
       }
     }
 
-    Set<ClassBuilder> blackListedClasses = new Set<ClassBuilder>();
+    Set<ClassBuilder> denyListedClasses = new Set<ClassBuilder>();
     for (int i = 0; i < denylistedCoreClasses.length; i++) {
-      blackListedClasses.add(coreLibrary
+      denyListedClasses.add(coreLibrary
           .lookupLocalMember(denylistedCoreClasses[i], required: true));
     }
 
@@ -698,7 +698,7 @@ class SourceLoader extends Loader {
         }
         if (allSupertypesProcessed) {
           topologicallySortedClasses.add(cls);
-          checkClassSupertypes(cls, directSupertypeMap, blackListedClasses);
+          checkClassSupertypes(cls, directSupertypeMap, denyListedClasses);
         } else {
           workList.add(cls);
         }
@@ -748,8 +748,8 @@ class SourceLoader extends Loader {
   void checkClassSupertypes(
       SourceClassBuilder cls,
       Map<TypeDeclarationBuilder, TypeAliasBuilder> directSupertypeMap,
-      Set<ClassBuilder> blackListedClasses) {
-    // Check that the direct supertypes aren't black-listed or enums.
+      Set<ClassBuilder> denyListedClasses) {
+    // Check that the direct supertypes aren't deny-listed or enums.
     List<TypeDeclarationBuilder> directSupertypes =
         directSupertypeMap.keys.toList();
     for (int i = 0; i < directSupertypes.length; i++) {
@@ -758,7 +758,7 @@ class SourceLoader extends Loader {
         cls.addProblem(templateExtendingEnum.withArguments(supertype.name),
             cls.charOffset, noLength);
       } else if (!cls.library.mayImplementRestrictedTypes &&
-          blackListedClasses.contains(supertype)) {
+          denyListedClasses.contains(supertype)) {
         TypeAliasBuilder aliasBuilder = directSupertypeMap[supertype];
         if (aliasBuilder != null) {
           cls.addProblem(
@@ -801,7 +801,7 @@ class SourceLoader extends Loader {
                 ]);
             return;
           } else if (!cls.library.mayImplementRestrictedTypes &&
-              blackListedClasses.contains(builder)) {
+              denyListedClasses.contains(builder)) {
             cls.addProblem(
                 templateExtendingRestricted
                     .withArguments(mixedInTypeBuilder.fullNameForErrors),

pkg/front_end/test/spell_checking_list_code.txt

@@ -603,6 +603,7 @@ mangled
 manipulation
 markdown
 masking
+master
 matcher
 mb
 md

pkg/front_end/test/spell_checking_list_common.txt

@@ -772,6 +772,7 @@ denote
 denoted
 denotes
 denoting
+deny
 depend
 dependence
 dependencies
@@ -1769,7 +1770,6 @@ markers
 marking
 marks
 mask
-master
 match
 matched
 matcher

pkg/front_end/test/spell_checking_list_denylist.txt

@@ -10,6 +10,10 @@
 # automatic tools might move it to the top of the file.
 
 alread
+blacklist
+black-list
+blacklisted
+black-listed
 chnage
 clonable
 comile
@@ -69,6 +73,7 @@ reuslt
 satifying
 seach
 singluar
+slave
 Specifiction
 staments
 statment
@@ -79,4 +84,8 @@ suffient
 terminted
 tood
 unlinke
-valiation
+valiation
+whitelist
+white-list
+whitelisted
+white-listed

pkg/test_runner/lib/src/options.dart

@@ -353,7 +353,7 @@ compiler.''',
 
   /// For printing out reproducing command lines, we don't want to add these
   /// options.
-  static final _blacklistedOptions = {
+  static final _denylistedOptions = {
     'build_directory',
     'chrome',
     'clean_exit',
@@ -585,7 +585,7 @@ compiler.''',
     for (var option in _options) {
       var name = option.name;
       if (!data.containsKey(name) ||
-          _blacklistedOptions.contains(name) ||
+          _denylistedOptions.contains(name) ||
           (usingNamedConfiguration &&
               _namedConfigurationOptions.contains(name))) {
         continue;