[vm/aot/tfa] Update TFA unit tests to work with constants-update-2018

Normally, TFA runs after constant evaluation and it expects @pragma
annotations in the evaluated form. In unit tests TFA runs after
front-end and it was expecting @pragma annotations in the expression
form. With constants-update-2018 front-end starts evaluating constants,
so TFA unit tests should switch from ExpressionPragmaAnnotationParser
to ConstantPragmaAnnotationParser.

This CL does not update test expectations as flag is not flipped yet.
Test expectations should be updated when flipping a flag using

  tools/test.py -m release --vm-options -DupdateExpectations=true pkg/vm

Change-Id: I94ee2de9f70328ce3ed3ffd9902a92eeb26d3a29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108840
Reviewed-by: Martin Kustermann <[email protected]>
Reviewed-by: Vyacheslav Egorov <[email protected]>
Reviewed-by: Samir Jindel <[email protected]>
Commit-Queue: Alexander Markov <[email protected]>

Author: alexmarkov

pkg/front_end/lib/src/api_unstable/vm.dart

@@ -8,6 +8,9 @@ export '../api_prototype/compiler_options.dart'
 export '../api_prototype/diagnostic_message.dart'
     show DiagnosticMessage, DiagnosticMessageHandler, getMessageUri;
 
+export '../api_prototype/experimental_flags.dart'
+    show defaultExperimentalFlags, ExperimentalFlag;
+
 export '../api_prototype/file_system.dart'
     show FileSystem, FileSystemEntity, FileSystemException;
 

pkg/vm/lib/transformations/pragma.dart

@@ -50,10 +50,14 @@ class ConstantPragmaAnnotationParser extends PragmaAnnotationParser {
     if (annotation is ConstantExpression) {
       Constant constant = annotation.constant;
       if (constant is InstanceConstant) {
-        if (constant.classReference.node == coreTypes.pragmaClass) {
+        if (constant.classNode == coreTypes.pragmaClass) {
           pragmaConstant = constant;
         }
+      } else if (constant is UnevaluatedConstant) {
+        throw 'Error: unevaluated constant $constant';
       }
+    } else {
+      throw 'Error: non-constant annotation $annotation';
     }
     if (pragmaConstant == null) return null;
 

pkg/vm/test/common_test_utils.dart

@@ -41,6 +41,7 @@ Future<Component> compileTestCaseToKernelProgram(Uri sourceUri,
   final options = new CompilerOptions()
     ..target = target
     ..linkedDependencies = <Uri>[platformKernel]
+    ..environmentDefines = <String, String>{}
     ..onDiagnostic = (DiagnosticMessage message) {
       fail("Compilation error: ${message.plainTextFormatted.join('\n')}");
     };

pkg/vm/test/transformations/type_flow/summary_collector_test.dart

@@ -4,15 +4,19 @@
 
 import 'dart:io';
 
+import 'package:front_end/src/api_unstable/vm.dart'
+    show defaultExperimentalFlags, ExperimentalFlag;
 import 'package:kernel/ast.dart';
 import 'package:kernel/class_hierarchy.dart';
 import 'package:kernel/core_types.dart';
 import 'package:kernel/type_environment.dart';
 import 'package:test/test.dart';
+import 'package:vm/transformations/pragma.dart'
+    show ConstantPragmaAnnotationParser;
 import 'package:vm/transformations/type_flow/native_code.dart';
 import 'package:vm/transformations/type_flow/summary_collector.dart';
 import 'package:vm/transformations/type_flow/analysis.dart';
-import 'annotation_matcher.dart';
+import 'annotation_matcher.dart' show ExpressionPragmaAnnotationParser;
 import 'package:kernel/target/targets.dart';
 
 import '../../common_test_utils.dart';
@@ -31,7 +35,10 @@ class PrintSummaries extends RecursiveVisitor<Null> {
             hierarchy,
             new EmptyEntryPointsListener(),
             new NativeCodeOracle(
-                null, new ExpressionPragmaAnnotationParser(coreTypes)),
+                null,
+                defaultExperimentalFlags[ExperimentalFlag.constantUpdate2018]
+                    ? new ConstantPragmaAnnotationParser(coreTypes)
+                    : new ExpressionPragmaAnnotationParser(coreTypes)),
             new GenericInterfacesInfoImpl(hierarchy));
 
   String print(TreeNode node) {

pkg/vm/test/transformations/type_flow/transformer_test.dart

@@ -4,11 +4,15 @@
 
 import 'dart:io';
 
+import 'package:front_end/src/api_unstable/vm.dart'
+    show defaultExperimentalFlags, ExperimentalFlag;
 import 'package:kernel/target/targets.dart';
 import 'package:kernel/ast.dart';
 import 'package:kernel/core_types.dart';
 import 'package:kernel/kernel.dart';
 import 'package:test/test.dart';
+import 'package:vm/transformations/pragma.dart'
+    show ConstantPragmaAnnotationParser;
 import 'package:vm/transformations/type_flow/transformer.dart'
     show transformComponent;
 import 'annotation_matcher.dart';
@@ -24,8 +28,13 @@ runTestCase(Uri source) async {
 
   final coreTypes = new CoreTypes(component);
 
-  component = transformComponent(target, coreTypes, component,
-      new ExpressionPragmaAnnotationParser(coreTypes));
+  component = transformComponent(
+      target,
+      coreTypes,
+      component,
+      defaultExperimentalFlags[ExperimentalFlag.constantUpdate2018]
+          ? new ConstantPragmaAnnotationParser(coreTypes)
+          : new ExpressionPragmaAnnotationParser(coreTypes));
 
   final actual = kernelLibraryToString(component.mainMethod.enclosingLibrary);