Skip to content

Commit 3798e5c

Browse files
joshualittcommit-bot@chromium.org
authored andcommitted
[dart2js] Fix some compilation errors in dart2js/native.
Change-Id: Idb614189a31ceaeb53a9acb1f23f0ff3f46eb9c4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150666 Reviewed-by: Stephen Adams <[email protected]> Commit-Queue: Joshua Litt <[email protected]>
1 parent 0d3e77d commit 3798e5c

14 files changed

+22
-22
lines changed

tests/dart2js/native/field_type2_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import 'native_testing.dart';
99

1010
@Native("Node")
1111
class Node {
12-
final parentNode;
12+
get parentNode native;
1313
}
1414

1515
makeNode(parent) native;

tests/dart2js/native/field_type_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import "native_testing.dart";
1010

1111
@Native("Node")
1212
class Node {
13-
final Node parentNode;
13+
Node get parentNode native;
1414

1515
ModelSource _modelSource; // If null, inherited from parent.
1616

tests/dart2js/native/native_exceptions1_frog_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import 'native_testing.dart';
2020
class E {
2121
E._used() native; // Bogus native constructor, called only from fake body.
2222

23-
final int code;
23+
int get code native;
2424
}
2525

2626
// Type with exception-throwing methods.

tests/dart2js/native/native_mixin_with_plain_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import "native_testing.dart";
99

1010
@Native("A")
1111
class A {
12-
final String aa;
12+
String get aa native;
1313
foo() => "A-foo $aa";
1414
baz() => "A-baz $aa";
1515
}

tests/dart2js/native/native_window1_frog_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
import "native_testing.dart";
66

77
abstract class Window {
8-
final int document;
8+
int get document native;
99
}
1010

1111
// Defining this global object makes Frog eager on optimizing
1212
// call sites where the receiver is typed 'Window'.
1313
@Native("@*DOMWindow")
1414
class _DOMWindowJs implements Window {
15-
final int document;
15+
int get document native;
1616
}
1717

1818
class Win implements Window {

tests/dart2js/native/native_window2_frog_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
import "native_testing.dart";
66

77
abstract class Window {
8-
final int document;
8+
int get document native;
99
}
1010

1111
// Defining this global object makes Frog eager on optimizing
1212
// call sites where the receiver is typed 'Window'.
1313
@Native("@*DOMWindow")
1414
class _DOMWindowJs implements Window {
15-
final int document;
15+
int get document native;
1616
}
1717

1818
class Win implements Window {

tests/dart2js/native/subclassing_constructor_1_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ var log;
1717
@Native("A")
1818
class A {
1919
final a1 = log(101); // Only initialized IF named constructor called.
20-
final a2; // Initialized by native constructor.
21-
final a3; // Initialized only by A.two.
20+
get a2 native; // Initialized by native constructor.
21+
var a3; // Initialized only by A.two.
2222
var a4 = log(104);
2323

2424
A.one();
@@ -37,7 +37,7 @@ class A {
3737
}
3838

3939
class B extends A {
40-
final b1;
40+
var b1;
4141
final b2 = log(202);
4242
var b3;
4343

tests/dart2js_2/native/field_type2_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import 'native_testing.dart';
1111

1212
@Native("Node")
1313
class Node {
14-
final parentNode;
14+
get parentNode native;
1515
}
1616

1717
makeNode(parent) native;

tests/dart2js_2/native/field_type_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import "native_testing.dart";
1212

1313
@Native("Node")
1414
class Node {
15-
final Node parentNode;
15+
Node get parentNode native;
1616

1717
ModelSource _modelSource; // If null, inherited from parent.
1818

tests/dart2js_2/native/native_exceptions1_frog_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import 'native_testing.dart';
2222
class E {
2323
E._used() native; // Bogus native constructor, called only from fake body.
2424

25-
final int code;
25+
int get code native;
2626
}
2727

2828
// Type with exception-throwing methods.

0 commit comments

Comments
 (0)