Analyzer: Do not forward factory constructors to mixin applications

Fixes #38306

Change-Id: I1424425ad6b04f1b611661cfca6ff5113b2cf0df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150681
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analyzer/lib/src/dart/element/element.dart

@@ -993,7 +993,7 @@ class ClassElementImpl extends AbstractClassElementImpl
   /// Compute a list of constructors for this class, which is a mixin
   /// application.  If specified, [visitedClasses] is a list of the other mixin
   /// application classes which have been visited on the way to reaching this
-  /// one (this is used to detect circularities).
+  /// one (this is used to detect cycles).
   List<ConstructorElement> _computeMixinAppConstructors(
       [List<ClassElementImpl> visitedClasses]) {
     if (supertype == null) {
@@ -1012,7 +1012,8 @@ class ClassElementImpl extends AbstractClassElementImpl
     if (!superElement.isMixinApplication) {
       var library = this.library;
       constructorsToForward = superElement.constructors
-          .where((constructor) => constructor.isAccessibleIn(library));
+          .where((constructor) => constructor.isAccessibleIn(library))
+          .where((constructor) => !constructor.isFactory);
     } else {
       if (visitedClasses == null) {
         visitedClasses = <ClassElementImpl>[this];

pkg/analyzer/test/src/diagnostics/undefined_method_test.dart

@@ -179,6 +179,25 @@ f() { A?.m(); }
 ''');
   }
 
+  test_static_mixinApplication_superConstructorIsFactory() async {
+    await assertErrorsInCode(r'''
+mixin M {}
+
+class A {
+  A();
+  factory A.named() = A;
+}
+
+class B = A with M;
+
+void main() {
+  B.named();
+}
+''', [
+      error(StaticTypeWarningCode.UNDEFINED_METHOD, 96, 5),
+    ]);
+  }
+
   test_withExtension() async {
     await assertErrorsInCode(r'''
 class C {}

pkg/analyzer/test/src/summary/resynthesize_common.dart

@@ -308,8 +308,6 @@ class alias MixinApp extends Base with M {
   synthetic MixinApp.requiredArg(dynamic x) = Base.requiredArg;
   synthetic MixinApp.positionalArg([bool x = true]) = Base.positionalArg;
   synthetic MixinApp.namedArg({int x: 42}) = Base.namedArg;
-  synthetic MixinApp.fact() = Base.fact;
-  synthetic MixinApp.fact2() = Base.fact2;
 }
 ''');
   }