Skip to content

Commit 2c26ece

Browse files
rakudramacommit-bot@chromium.org
authored andcommitted
[gardening] Fix non-web-integer in corelib_2/num_parse_test
Change-Id: Ie89d5065cc6a3c3a05f8bf52c57b8f082a830b2c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108760 Reviewed-by: Lasse R.H. Nielsen <[email protected]> Commit-Queue: Stephen Adams <[email protected]>
1 parent 1eb1520 commit 2c26ece

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

tests/corelib_2/corelib_2.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ integer_to_string_test/01: RuntimeError
3939
integer_to_string_test/01: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
4040
iterable_return_type_test/02: RuntimeError # Dart2js does not support Uint64*.
4141
list_unmodifiable_test: Pass, RuntimeError # Issue 28712
42-
num_parse_test/01: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
43-
num_parse_test/none: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
4442

4543
[ $compiler != dartdevc ]
4644
error_stack_trace_test/static: MissingCompileTimeError
@@ -316,8 +314,6 @@ list_concurrent_modify_test: RuntimeError # DDC uses ES6 array iterators so it d
316314
list_removeat_test: RuntimeError # Issue 29921
317315
main_test: RuntimeError # Issue 29921
318316
nan_infinity_test/01: RuntimeError # Issue 29921
319-
num_parse_test/01: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
320-
num_parse_test/none: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
321317
regexp/alternative-length-miscalculation_test: RuntimeError # Issue 29921
322318
regexp/ascii-regexp-subject_test: RuntimeError # Issue 29921
323319
regexp/bol-with-multiline_test: RuntimeError # Issue 29921

tests/corelib_2/num_parse_test.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,9 @@ void main() {
135135
testIntAround(0x10000000000000); // 2^52
136136
testIntAround(0x20000000000000); // 2^53
137137
testIntAround(0x40000000000000); // 2^54
138-
testIntAround(0x7ffffffffffffffe); // 2^63
138+
// 0x7ffffffffffffffe on int-is-64-bit implementations, rounded up on
139+
// int-is-double implementations.
140+
testIntAround(0x7ffffffffffff000 + 0xffe); // 2^63
139141

140142
testDouble(0.0);
141143
testDouble(5e-324);

0 commit comments

Comments
 (0)