analyzer: introduce the 'flutter' lint rule category

srawlins · Commit Queue · commit 1c06d66d741a · 2024-07-15T20:48:14.000Z
12 lint rules go into this category. Work towards https://github.com/dart-lang/linter/issues/4991 I also found some rules that were mis-categorized as 'style' that should be in a different category. Probably copy-paste errors. Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try Change-Id: Iae5aa15f389fc2a4c9bb4f39fd855696b4202ac5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/375062 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Phil Quitslund <pquitslund@google.com>
diff --git a/pkg/analyzer/lib/src/lint/linter.dart b/pkg/analyzer/lib/src/lint/linter.dart
@@ -56,6 +56,9 @@ abstract final class Category {
   /// A category of rules that protect against error-prone code.
   static const String errorProne = 'error-prone';
 
+  /// A category of rules that help to write Flutter code.
+  static const String flutter = 'flutter';
+
   /// A category of rules that promote language feature usage.
   static const String languageFeatureUsage = 'language feature usage';
 
diff --git a/pkg/linter/lib/src/rules/avoid_js_rounded_ints.dart b/pkg/linter/lib/src/rules/avoid_js_rounded_ints.dart
@@ -44,7 +44,7 @@ class AvoidJsRoundedInts extends LintRule {
             name: 'avoid_js_rounded_ints',
             description: _desc,
             details: _details,
-            categories: {Category.style});
+            categories: {Category.errorProne});
 
   @override
   LintCode get lintCode => code;
diff --git a/pkg/linter/lib/src/rules/avoid_renaming_method_parameters.dart b/pkg/linter/lib/src/rules/avoid_renaming_method_parameters.dart
@@ -58,7 +58,7 @@ class AvoidRenamingMethodParameters extends LintRule {
             name: 'avoid_renaming_method_parameters',
             description: _desc,
             details: _details,
-            categories: {Category.style});
+            categories: {Category.documentationCommentMaintenance});
 
   @override
   LintCode get lintCode => parameterCode;
diff --git a/pkg/linter/lib/src/rules/avoid_shadowing_type_parameters.dart b/pkg/linter/lib/src/rules/avoid_shadowing_type_parameters.dart
@@ -39,7 +39,7 @@ class AvoidShadowingTypeParameters extends LintRule {
             name: 'avoid_shadowing_type_parameters',
             description: _desc,
             details: _details,
-            categories: {Category.style});
+            categories: {Category.errorProne});
 
   @override
   LintCode get lintCode => code;
diff --git a/pkg/linter/lib/src/rules/avoid_unnecessary_containers.dart b/pkg/linter/lib/src/rules/avoid_unnecessary_containers.dart
@@ -60,7 +60,7 @@ class AvoidUnnecessaryContainers extends LintRule {
             name: 'avoid_unnecessary_containers',
             description: _desc,
             details: _details,
-            categories: {Category.style});
+            categories: {Category.flutter, Category.style});
 
   @override
   LintCode get lintCode => code;
diff --git a/pkg/linter/lib/src/rules/avoid_web_libraries_in_flutter.dart b/pkg/linter/lib/src/rules/avoid_web_libraries_in_flutter.dart
@@ -56,7 +56,7 @@ class AvoidWebLibrariesInFlutter extends LintRule {
             name: 'avoid_web_libraries_in_flutter',
             description: _desc,
             details: _details,
-            categories: {Category.errorProne});
+            categories: {Category.errorProne, Category.flutter});
 
   @override
   LintCode get lintCode => code;
diff --git a/pkg/linter/lib/src/rules/cast_nullable_to_non_nullable.dart b/pkg/linter/lib/src/rules/cast_nullable_to_non_nullable.dart
@@ -48,7 +48,7 @@ class CastNullableToNonNullable extends LintRule {
           name: 'cast_nullable_to_non_nullable',
           description: _desc,
           details: _details,
-          categories: {Category.style},
+          categories: {Category.errorProne},
         );
 
   @override
diff --git a/pkg/linter/lib/src/rules/conditional_uri_does_not_exist.dart b/pkg/linter/lib/src/rules/conditional_uri_does_not_exist.dart
@@ -42,7 +42,7 @@ class ConditionalUriDoesNotExist extends LintRule {
             name: 'conditional_uri_does_not_exist',
             description: _desc,
             details: _details,
-            categories: {Category.style});
+            categories: {Category.errorProne});
 
   @override
   LintCode get lintCode => code;
diff --git a/pkg/linter/lib/src/rules/diagnostic_describe_all_properties.dart b/pkg/linter/lib/src/rules/diagnostic_describe_all_properties.dart
@@ -77,7 +77,7 @@ class DiagnosticDescribeAllProperties extends LintRule {
           name: 'diagnostic_describe_all_properties',
           description: _desc,
           details: _details,
-          categories: {Category.errorProne},
+          categories: {Category.errorProne, Category.flutter},
         );
 
   @override
diff --git a/pkg/linter/lib/src/rules/no_logic_in_create_state.dart b/pkg/linter/lib/src/rules/no_logic_in_create_state.dart
@@ -69,7 +69,7 @@ class NoLogicInCreateState extends LintRule {
             name: 'no_logic_in_create_state',
             description: _desc,
             details: _details,
-            categories: {Category.errors});
+            categories: {Category.errors, Category.flutter});
 
   @override
   LintCode get lintCode => code;
diff --git a/pkg/linter/lib/src/rules/no_runtimeType_toString.dart b/pkg/linter/lib/src/rules/no_runtimeType_toString.dart
@@ -50,7 +50,7 @@ class NoRuntimeTypeToString extends LintRule {
             name: 'no_runtimeType_toString',
             description: _desc,
             details: _details,
-            categories: {Category.style});
+            categories: {Category.nonPerformant});
 
   @override
   LintCode get lintCode => code;
diff --git a/pkg/linter/lib/src/rules/null_closures.dart b/pkg/linter/lib/src/rules/null_closures.dart
@@ -214,7 +214,7 @@ class NullClosures extends LintRule {
             name: 'null_closures',
             description: _desc,
             details: _details,
-            categories: {Category.style});
+            categories: {Category.errorProne});
 
   @override
   LintCode get lintCode => code;
diff --git a/pkg/linter/lib/src/rules/sized_box_for_whitespace.dart b/pkg/linter/lib/src/rules/sized_box_for_whitespace.dart
@@ -58,7 +58,7 @@ class SizedBoxForWhitespace extends LintRule {
             name: 'sized_box_for_whitespace',
             description: _desc,
             details: _details,
-            categories: {Category.style});
+            categories: {Category.flutter, Category.style});
 
   @override
   LintCode get lintCode => code;
diff --git a/pkg/linter/lib/src/rules/sized_box_shrink_expand.dart b/pkg/linter/lib/src/rules/sized_box_shrink_expand.dart
@@ -71,7 +71,7 @@ class SizedBoxShrinkExpand extends LintRule {
             name: 'sized_box_shrink_expand',
             description: 'Use SizedBox shrink and expand named constructors.',
             details: _details,
-            categories: {Category.style});
+            categories: {Category.flutter, Category.style});
 
   @override
   LintCode get lintCode => code;
diff --git a/pkg/linter/lib/src/rules/sort_child_properties_last.dart b/pkg/linter/lib/src/rules/sort_child_properties_last.dart
@@ -92,7 +92,7 @@ class SortChildPropertiesLast extends LintRule {
             name: 'sort_child_properties_last',
             description: _desc,
             details: _details,
-            categories: {Category.style});
+            categories: {Category.flutter, Category.style});
 
   @override
   LintCode get lintCode => code;
diff --git a/pkg/linter/lib/src/rules/use_build_context_synchronously.dart b/pkg/linter/lib/src/rules/use_build_context_synchronously.dart
@@ -977,7 +977,7 @@ class UseBuildContextSynchronously extends LintRule {
           name: 'use_build_context_synchronously',
           description: _desc,
           details: _details,
-          categories: {Category.errorProne},
+          categories: {Category.errorProne, Category.flutter},
           state: State.stable(since: Version(3, 2, 0)),
         );
 
diff --git a/pkg/linter/lib/src/rules/use_colored_box.dart b/pkg/linter/lib/src/rules/use_colored_box.dart
@@ -48,7 +48,7 @@ class UseColoredBox extends LintRule {
             name: 'use_colored_box',
             description: _desc,
             details: _details,
-            categories: {Category.style});
+            categories: {Category.flutter, Category.style});
 
   @override
   LintCode get lintCode => code;
diff --git a/pkg/linter/lib/src/rules/use_decorated_box.dart b/pkg/linter/lib/src/rules/use_decorated_box.dart
@@ -58,7 +58,7 @@ class UseDecoratedBox extends LintRule {
             name: 'use_decorated_box',
             description: _desc,
             details: _details,
-            categories: {Category.style});
+            categories: {Category.flutter, Category.style});
 
   @override
   LintCode get lintCode => code;
diff --git a/pkg/linter/lib/src/rules/use_full_hex_values_for_flutter_colors.dart b/pkg/linter/lib/src/rules/use_full_hex_values_for_flutter_colors.dart
@@ -43,7 +43,7 @@ class UseFullHexValuesForFlutterColors extends LintRule {
             name: 'use_full_hex_values_for_flutter_colors',
             description: _desc,
             details: _details,
-            categories: {Category.style});
+            categories: {Category.flutter, Category.style});
 
   @override
   LintCode get lintCode => code;
diff --git a/pkg/linter/lib/src/rules/use_key_in_widget_constructors.dart b/pkg/linter/lib/src/rules/use_key_in_widget_constructors.dart
@@ -44,7 +44,7 @@ class UseKeyInWidgetConstructors extends LintRule {
             name: 'use_key_in_widget_constructors',
             description: _desc,
             details: _details,
-            categories: {Category.style});
+            categories: {Category.flutter, Category.style});
 
   @override
   LintCode get lintCode => code;
