[wildcard-variables] Add 'no_wildcard_variable_uses' lint to breaking change section. #3785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pq
approved these changes
May 7, 2024
Member
pq
left a comment
pq
left a comment
There was a problem hiding this comment.
Bob or Eric may suggest some word-smithing but content LGTM!
eernstg
reviewed
May 8, 2024
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
LGTM!
Just adding a comment that we might want to use a lint which is more precisely targeted at the references to _ which will actually break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds information about the existing
no_wildcard_variable_useslint which should help the migration of the wildcards feature.It's already a core lint and should be enabled in most projects, meaning that the breakage for the wildcards feature should be small.
Anyways, writing is hard -- so let me know if I should add/remove/change something. Thanks 😄