From 51a3ab2e6af7703c6331476398b1368318114ab0 Mon Sep 17 00:00:00 2001 From: Moritz Date: Wed, 1 Oct 2025 09:59:27 +0200 Subject: [PATCH 1/3] Rename comments --- .github/workflows/health_base.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/health_base.yaml b/.github/workflows/health_base.yaml index 516d6af9..9c92e1dd 100644 --- a/.github/workflows/health_base.yaml +++ b/.github/workflows/health_base.yaml @@ -214,4 +214,4 @@ jobs: uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 with: name: comment-${{ inputs.check }} - path: current_repo/output/comment.md + path: current_repo/output/comment-${{ inputs.check }}.md From 7ba6f991ded7b0512b3c56b9eb2cef1789763256 Mon Sep 17 00:00:00 2001 From: Moritz Date: Wed, 1 Oct 2025 11:00:21 +0200 Subject: [PATCH 2/3] Fix other locations --- .github/workflows/health_base.yaml | 2 +- pkgs/firehose/lib/src/health/health.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/health_base.yaml b/.github/workflows/health_base.yaml index 9c92e1dd..f72e70c5 100644 --- a/.github/workflows/health_base.yaml +++ b/.github/workflows/health_base.yaml @@ -197,7 +197,7 @@ jobs: --experiments ${{ inputs.experiments }} \ --health_yaml_name ${{ inputs.health_yaml_name }} - - run: test -f current_repo/output/comment.md || echo $'The ${{ inputs.check }} workflow has encountered an exception and did not complete.' >> current_repo/output/comment.md + - run: test -f current_repo/output/comment-${{ inputs.check }}.md || echo $'The ${{ inputs.check }} workflow has encountered an exception and did not complete.' >> current_repo/output/comment-${{ inputs.check }}.md if: ${{ '$action_state' == 1 }} - name: Upload coverage to Coveralls diff --git a/pkgs/firehose/lib/src/health/health.dart b/pkgs/firehose/lib/src/health/health.dart index 5d442645..a751d018 100644 --- a/pkgs/firehose/lib/src/health/health.dart +++ b/pkgs/firehose/lib/src/health/health.dart @@ -63,7 +63,7 @@ class Health { path.join( directory.path, 'output', - 'comment.md', + 'comment-${check.displayName}.md', ) { flutterExecutable = (Process.runSync('which', ['-a', 'flutter']).stdout as String) From 897e321543020df2002e2190cd56ddd79e5b158d Mon Sep 17 00:00:00 2001 From: Moritz Date: Wed, 1 Oct 2025 12:53:42 +0200 Subject: [PATCH 3/3] add changelog --- pkgs/firehose/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/pkgs/firehose/CHANGELOG.md b/pkgs/firehose/CHANGELOG.md index 51949cc6..6ff09896 100644 --- a/pkgs/firehose/CHANGELOG.md +++ b/pkgs/firehose/CHANGELOG.md @@ -2,6 +2,7 @@ - Make the PR health output less verbose by collapsing warnings by default. - Bump dart_apitool to fix errors with equal types being reported as different. +- Give comment files in health work. ## 0.12.0