Skip to content

Conversation

@srawlins
Copy link
Member

This change would have more teeth to it if we had a lint rule that guarded against interpolating null into a string (dart-lang/sdk#58615), but I think it still makes the code a teensy bit safer / more readable.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins
Copy link
Member Author

CC @dart-lang/analyzer-team

@srawlins srawlins merged commit 6330a13 into dart-lang:main Jun 18, 2024
@srawlins srawlins deleted the local-hrefs branch June 18, 2024 18:24
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jun 20, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/818d1f5..6330a13):
  6330a13e  2024-06-18  Sam Rawlins  Declare local variables for the 'href' field, to promote and avoid printing 'null' (dart-lang/dartdoc#3788)
  822ca007  2024-06-18  Sam Rawlins  Stop supporting '[this]' as a comment reference. (dart-lang/dartdoc#3765)

ecosystem (https://github.com/dart-lang/ecosystem/compare/8ada2ee..31148cd):
  31148cd  2024-06-20  Devon Carew  cosmetic update to the triager's comment format (dart-lang/ecosystem#273)

glob (https://github.com/dart-lang/glob/compare/eaec6a4..6d3ba5e):
  6d3ba5e  2024-06-20  Kevin Moore  update lints (dart-archive/glob#95)

logging (https://github.com/dart-lang/logging/compare/dbd6829..240ec33):
  240ec33  2024-06-20  Kevin Moore  Update lints dep, bump min SDK (dart-archive/logging#167)

Change-Id: I2a691c3a4d02f55a625afaa855ab3e5aa60259c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372520
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants