Skip to content

Commit f8486e5

Browse files
authored
Remove support for dart2js and dartanalyzer (#91)
Closes #89 The dartanalyzer support has been broken by a changed errorformat and has not been used enough for anyone to complain. The dart2js support has had little usage and is only usable from an entrypoint to start with so most workflows likely use a different approach. Leave an error message pointing to an issue with discussion about the removal so that if users hit this they can comment and we can re-open. In the long term we can remove these commands entirely.
1 parent 8eee349 commit f8486e5

File tree

4 files changed

+6
-34
lines changed

4 files changed

+6
-34
lines changed

Dart2Js.gif

-260 KB
Binary file not shown.

DartAnalyzer.gif

-253 KB
Binary file not shown.

README.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,6 @@ Looking for an IDE experience? See the [Dart Tools][] page.
1616

1717
## Commands
1818

19-
You can use following vim commands:
20-
21-
### :Dart2Js
22-
23-
![](https://raw.github.com/dart-lang/dart-vim-plugin/master/Dart2Js.gif)
24-
25-
### :DartAnalyzer
26-
27-
![](https://raw.github.com/dart-lang/dart-vim-plugin/master/DartAnalyzer.gif)
28-
2919
### :DartFmt
3020

3121
![](https://raw.github.com/dart-lang/dart-vim-plugin/master/DartFmt.gif)

autoload/dart.vim

Lines changed: 6 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -67,33 +67,15 @@ function! s:FindDartFmt() abort
6767
endfunction
6868

6969
function! dart#analyzer(q_args) abort
70-
if executable('dartanalyzer')
71-
let path = expand('%:p:gs:\:/:')
72-
if filereadable(path)
73-
let command = printf('dartanalyzer %s %s', a:q_args, shellescape(path))
74-
let lines = systemlist(command)
75-
call s:cexpr('%m (%f\, line %l\, col %c)', lines, 'dartanalyzer')
76-
else
77-
call s:error(printf('cannot read a file: "%s"', path))
78-
endif
79-
else
80-
call s:error('cannot execute binary file: dartanalyzer')
81-
endif
70+
call s:error('DartAnalyzer support has been removed. '.
71+
\'If this broke your workflow please comment on '.
72+
\'https://github.com/dart-lang/dart-vim-plugin/issues/89')
8273
endfunction
8374

8475
function! dart#tojs(q_args) abort
85-
if executable('dart2js')
86-
let path = expand('%:p:gs:\:/:')
87-
if filereadable(path)
88-
let command = printf('dart2js %s %s', a:q_args, shellescape(path))
89-
let lines = systemlist(command)
90-
call s:cexpr('%m (%f\, line %l\, col %c)', lines, 'dart2js')
91-
else
92-
call s:error(printf('cannot read a file: "%s"', path))
93-
endif
94-
else
95-
call s:error('cannot execute binary file: dartanalyzer')
96-
endif
76+
call s:error('Dart2JS support has been removed. '.
77+
\'If this broke your workflow please comment on '.
78+
\'https://github.com/dart-lang/dart-vim-plugin/issues/89')
9779
endfunction
9880

9981
" Finds the path to `uri`.

0 commit comments

Comments
 (0)