Skip to content

Conversation

@annagrin
Copy link
Contributor

@annagrin annagrin commented Sep 1, 2021

Add --enable-experiment option to build daemon so webdev can pass it to the daemon.
This is needed to verify that debugger works with new language features.

Closes: #3180

@google-cla google-cla bot added the cla: yes Google is happy with the PR contributors label Sep 1, 2021
@annagrin annagrin requested a review from jakemac53 September 1, 2021 18:14
@jakemac53
Copy link
Contributor

I believe if you merge with master the failing test should be fixed

@google-cla
Copy link

google-cla bot commented Sep 2, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes Google is happy with the PR contributors labels Sep 2, 2021
@jakemac53
Copy link
Contributor

@googlebot I consent

@google-cla google-cla bot added cla: yes Google is happy with the PR contributors and removed cla: no labels Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Google is happy with the PR contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build_daemon does not support --enable-experiment option.

2 participants