Support --enable-experiment option in build daemon command (#3183)

* Support --enable-experiment option in build daemon command

* update daemon test to build an outline file

Co-authored-by: Jake Macdonald <[email protected]>

Author: Anna Gringauze

build_runner/CHANGELOG.md

@@ -1,4 +1,6 @@
-## 2.1.2-dev
+## 2.1.2
+
+- Support `--enable-experiment` option in build daemon.
 
 ## 2.1.1
 

build_runner/lib/src/entrypoint/daemon.dart

@@ -6,6 +6,7 @@ import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
+import 'package:build/experiments.dart';
 import 'package:build_daemon/constants.dart';
 import 'package:build_daemon/daemon.dart';
 import 'package:build_daemon/data/serializers.dart';
@@ -47,8 +48,13 @@ class DaemonCommand extends WatchCommand {
 
   @override
   Future<int> run() async {
-    var workingDirectory = Directory.current.path;
     var options = readOptions();
+    return withEnabledExperiments(
+        () => _run(options), options.enableExperiments);
+  }
+
+  Future<int> _run(DaemonOptions options) async {
+    var workingDirectory = Directory.current.path;
     var daemon = Daemon(workingDirectory);
     var requestedOptions = argResults!.arguments.toSet();
     if (!daemon.hasLock) {
@@ -94,7 +100,7 @@ $logEndMarker'''));
 
       // Forward server logs to daemon command STDIO.
       var logSub = builder.logs.listen((log) {
-        if (log.level > Level.INFO) {
+        if (log.level > Level.INFO || options.verbose) {
           var buffer = StringBuffer(log.message);
           if (log.error != null) buffer.writeln(log.error);
           if (log.stackTrace != null) buffer.writeln(log.stackTrace);

build_runner/pubspec.yaml

@@ -1,5 +1,5 @@
 name: build_runner
-version: 2.1.2-dev
+version: 2.1.2
 description: A build system for Dart code generation and modular compilation.
 repository: https://github.com/dart-lang/build/tree/master/build_runner
 

build_runner/test/daemon/daemon_test.dart

@@ -53,11 +53,18 @@ main() {
   // Don't actually use test package to speed up tests
   print('hello');
 }'''),
+      ]),
+      d.dir('lib', [
+        d.file('message.dart', '''
+const message = 'hello world';
+      '''),
       ]),
       d.dir('web', [
         d.file('main.dart', '''
+import 'package:a/message.dart';
+
 main() {
-  print('hello world');
+  print(message);
 }'''),
       ]),
     ]).create();
@@ -143,6 +150,20 @@ main() {
       ]).create();
     });
 
+    test('supports --enable-experiment option', () async {
+      await _startDaemon(options: ['--enable-experiment=fake-experiment']);
+      var client =
+          await _startClient(options: ['--enable-experiment=fake-experiment'])
+            ..registerBuildTarget(webTarget)
+            ..startBuild();
+      clients.add(client);
+      await expectLater(
+          client.buildResults,
+          // TODO: Check for specific message about a bad experiment
+          emitsThrough((BuildResults b) =>
+              b.results.first.status == BuildStatus.failed));
+    });
+
     test('does not shut down down on build script change when configured',
         () async {
       await _startDaemon(options: ['--skip-build-script-check']);