Skip to content

Commit 2159c90

Browse files
authored
update usages of deprecated analyzer apis (#3175)
1 parent a97fa40 commit 2159c90

File tree

7 files changed

+20
-13
lines changed

7 files changed

+20
-13
lines changed

build_resolvers/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 2.0.5-dev
2+
3+
- Update usages of deprecated analyzer apis.
4+
- Require at least analyzer `2.1.0`.
5+
16
## 2.0.4
27

38
- Allow analyzer version 2.x.x.

build_resolvers/lib/src/resolver.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,11 +170,11 @@ class AnalyzerResolver implements ReleasableResolver {
170170
var path = library.source.fullName;
171171

172172
if (resolve) {
173-
return (await session.getResolvedLibrary2(path) as ResolvedLibraryResult)
173+
return (await session.getResolvedLibrary(path) as ResolvedLibraryResult)
174174
.getElementDeclaration(element)
175175
?.node;
176176
} else {
177-
return (session.getParsedLibrary2(path) as ParsedLibraryResult)
177+
return (session.getParsedLibrary(path) as ParsedLibraryResult)
178178
.getElementDeclaration(element)
179179
?.node;
180180
}

build_resolvers/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
name: build_resolvers
2-
version: 2.0.4
2+
version: 2.0.5-dev
33
description: Resolve Dart code in a Builder
44
repository: https://github.com/dart-lang/build/tree/master/build_resolvers
55

66
environment:
77
sdk: ">=2.12.0 <3.0.0"
88

99
dependencies:
10-
analyzer: ">=1.5.0 <3.0.0"
10+
analyzer: ^2.1.0
1111
async: ^2.5.0
1212
build: ^2.0.0
1313
crypto: ^3.0.0

build_resolvers/test/resolver_test.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ int? get x => 1;
434434
sdkLanguageVersion.major);
435435
expect(lib.languageVersion.effective.minor,
436436
sdkLanguageVersion.minor);
437-
var errors = await lib.session.getErrors2('/a/web/main.dart')
437+
var errors = await lib.session.getErrors('/a/web/main.dart')
438438
as ErrorsResult;
439439
expect(errors.errors, isEmpty);
440440
}, resolvers: AnalyzerResolvers()),
@@ -452,7 +452,7 @@ int? get x => 1;
452452
expect(await resolver.isLibrary(AssetId('a', 'web/other.dart')), true);
453453
var newLib =
454454
await resolver.libraryFor(await resolver.assetIdForElement(lib));
455-
expect(await newLib.session.getResolvedLibraryByElement2(newLib),
455+
expect(await newLib.session.getResolvedLibraryByElement(newLib),
456456
isA<ResolvedLibraryResult>());
457457
}, resolvers: resolvers);
458458
});
@@ -751,7 +751,7 @@ int? get x => 1;
751751
expect(await resolver.isLibrary(AssetId('a', 'web/other.dart')), true);
752752

753753
// Validate that direct session usage would throw
754-
expect(() => lib.session.getParsedLibraryByElement2(x.library!),
754+
expect(() => lib.session.getParsedLibraryByElement(x.library!),
755755
throwsA(isA<InconsistentAnalysisException>()));
756756

757757
var astNode = await resolver.astNodeFor(x);
@@ -775,7 +775,7 @@ int? get x => 1;
775775
expect(await resolver.isLibrary(AssetId('a', 'web/other.dart')), true);
776776

777777
// Validate that direct session usage would throw
778-
expect(() => lib.session.getParsedLibraryByElement2(x.library!),
778+
expect(() => lib.session.getParsedLibraryByElement(x.library!),
779779
throwsA(isA<InconsistentAnalysisException>()));
780780

781781
var astNode = await resolver.astNodeFor(x, resolve: true);
@@ -796,11 +796,11 @@ int? get x => 1;
796796
var x = lib.topLevelElements.firstWhere((x) => !x.isSynthetic);
797797
expect(x.name, 'x');
798798
var originalResult = await lib.session
799-
.getResolvedLibrary2(lib.source.fullName) as ResolvedLibraryResult;
799+
.getResolvedLibrary(lib.source.fullName) as ResolvedLibraryResult;
800800
expect(await resolver.isLibrary(AssetId('a', 'web/other.dart')), true);
801801

802802
// Validate that direct session usage would throw
803-
expect(() => lib.session.getResolvedLibrary2(lib.source.fullName),
803+
expect(() => lib.session.getResolvedLibrary(lib.source.fullName),
804804
throwsA(isA<InconsistentAnalysisException>()));
805805

806806
var astNode = originalResult.getElementDeclaration(x)!.node;

build_test/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
## 2.1.4-dev
2+
13
## 2.1.3
24

35
- Use `allowedOutputs` in `TestBuilder` instead of computing them again.

build_test/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: build_test
22
description: Utilities for writing unit tests of Builders.
3-
version: 2.1.3
3+
version: 2.1.4-dev
44
repository: https://github.com/dart-lang/build/tree/master/build_test
55

66
environment:
@@ -25,5 +25,5 @@ dependencies:
2525
watcher: ^1.0.0
2626

2727
dev_dependencies:
28-
analyzer: ">=1.5.0 <3.0.0"
28+
analyzer: ^2.1.0
2929
collection: ^1.15.0

build_test/test/resolve_source_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ void main() {
126126
''', (resolver) => resolver.findLibraryNotNull('example'),
127127
packageConfig: packageConfig, inputId: AssetId('a', 'invalid.dart'));
128128
var errors = await libExample.session
129-
.getErrors2(libExample.source.fullName) as ErrorsResult;
129+
.getErrors(libExample.source.fullName) as ErrorsResult;
130130
expect(
131131
errors.errors.map((e) => e.message),
132132
contains(contains(

0 commit comments

Comments
 (0)