From 4139f8d5b75bbd3bdc190f938f4751381f7fe526 Mon Sep 17 00:00:00 2001 From: Patrice Chalin Date: Sat, 14 Jul 2018 17:01:47 -0400 Subject: [PATCH 1/3] chore: set max SDK version to <3.0.0 --- .travis.yml | 4 +++- CHANGELOG.md | 4 ++++ README.md | 6 ++++-- analysis_options.yaml | 1 - pubspec.yaml | 12 ++++++++---- test/typed_buffers_test.dart | 8 ++++---- 6 files changed, 23 insertions(+), 12 deletions(-) diff --git a/.travis.yml b/.travis.yml index ab911a8..e4d8442 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,7 +3,9 @@ dart: - dev dart_task: - - test: -p vm,firefox + - test: -p vm + xvfb: false + - test: -p firefox - dartfmt - dartanalyzer diff --git a/CHANGELOG.md b/CHANGELOG.md index 1855d95..3259e41 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## 1.1.7 + +* Set max SDK version to `<3.0.0`, and adjust other dependencies. + ## 1.1.6 * Update tests to work with Dart 2.0 64 bit ints. diff --git a/README.md b/README.md index c7a4772..9ec19ba 100644 --- a/README.md +++ b/README.md @@ -6,12 +6,14 @@ The `typed_data` package contains utility functions and classes that makes worki The `typed_data` package can be imported as - import 'package:typed_data/typed_data.dart'; +```dart +import 'package:typed_data/typed_data.dart'; +``` ## Typed buffers: Growable typed data lists Typed buffers are contains growable lists backed by typed arrays. -These are similar to the growable lists returned by `new List()`, +These are similar to the growable lists returned by `List()`, but stores typed data like a typed data list. ## Features and bugs diff --git a/analysis_options.yaml b/analysis_options.yaml index a10d4c5..2e6cdca 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -1,2 +1 @@ analyzer: - strong-mode: true diff --git a/pubspec.yaml b/pubspec.yaml index 98579db..0415f86 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,9 +1,13 @@ name: typed_data -version: 1.1.6 +version: 1.1.7 + author: Dart Team + description: Utility functions and classes related to the 'dart:typed_data' library. homepage: https://github.com/dart-lang/typed_data -dev_dependencies: - test: "^0.12.0" + environment: - sdk: ">=2.0.0-dev.16.0 <2.0.0" + sdk: '>=2.0.0-dev.16.0 <3.0.0' + +dev_dependencies: + test: ^1.2.0 diff --git a/test/typed_buffers_test.dart b/test/typed_buffers_test.dart index 53aa666..e7633dd 100644 --- a/test/typed_buffers_test.dart +++ b/test/typed_buffers_test.dart @@ -265,7 +265,7 @@ testFloat32x4Buffer(List floatSamples) { test("Float32x4Buffer", () { var buffer = new Float32x4Buffer(5); - expect(buffer, new isInstanceOf>()); + expect(buffer, TypeMatcher>()); expect(buffer.length, equals(5)); expect(buffer.elementSizeInBytes, equals(128 ~/ 8)); @@ -312,7 +312,7 @@ void testFloatBuffer( int bitSize, List samples, create(), double round(double v)) { test("Float${bitSize}Buffer", () { var buffer = create(); - expect(buffer, new isInstanceOf>()); + expect(buffer, TypeMatcher>()); int byteSize = bitSize ~/ 8; expect(buffer.length, equals(0)); @@ -380,7 +380,7 @@ void testInt32x4Buffer(List intSamples) { Matcher equals32x4(Int32x4 expected) => new MatchesInt32x4(expected); var buffer = new Int32x4Buffer(0); - expect(buffer, new isInstanceOf>()); + expect(buffer, TypeMatcher>()); expect(buffer.length, equals(0)); expect(buffer.elementSizeInBytes, equals(bytes)); @@ -439,7 +439,7 @@ void testIntBuffer( assert(round(max) == max); // All int buffers default to the value 0. var buffer = create(0); - expect(buffer, new isInstanceOf>()); + expect(buffer, TypeMatcher>()); expect(buffer.length, equals(0)); var bytes = bits ~/ 8; From fa1d2983ec657b7b8ce9f3cd5a56421730b19bdf Mon Sep 17 00:00:00 2001 From: Patrice Chalin Date: Sat, 14 Jul 2018 17:13:49 -0400 Subject: [PATCH 2/3] Skip tests known to be failing Due to #16. This will get the build green again. --- .travis.yml | 3 ++- pubspec.yaml | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index e4d8442..148e5a0 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,7 +5,8 @@ dart: dart_task: - test: -p vm xvfb: false - - test: -p firefox + # TODO: reinstate once https://github.com/dart-lang/typed_data/issues/16 is fixed + # - test: -p firefox - dartfmt - dartanalyzer diff --git a/pubspec.yaml b/pubspec.yaml index 0415f86..3ede0ae 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,9 +1,8 @@ name: typed_data version: 1.1.7 -author: Dart Team - description: Utility functions and classes related to the 'dart:typed_data' library. +author: Dart Team homepage: https://github.com/dart-lang/typed_data environment: From a4163c6d4900ac6f7f77f585bc45d8bff0b38d59 Mon Sep 17 00:00:00 2001 From: Patrice Chalin Date: Tue, 17 Jul 2018 17:24:30 -0400 Subject: [PATCH 3/3] Second pass adjustments based on reviewer feedback --- .travis.yml | 1 - analysis_options.yaml | 1 - pubspec.yaml | 2 +- test/typed_buffers_test.dart | 8 ++++---- 4 files changed, 5 insertions(+), 7 deletions(-) delete mode 100644 analysis_options.yaml diff --git a/.travis.yml b/.travis.yml index 148e5a0..01a7020 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,7 +4,6 @@ dart: dart_task: - test: -p vm - xvfb: false # TODO: reinstate once https://github.com/dart-lang/typed_data/issues/16 is fixed # - test: -p firefox - dartfmt diff --git a/analysis_options.yaml b/analysis_options.yaml deleted file mode 100644 index 2e6cdca..0000000 --- a/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -analyzer: diff --git a/pubspec.yaml b/pubspec.yaml index 3ede0ae..41f826b 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -9,4 +9,4 @@ environment: sdk: '>=2.0.0-dev.16.0 <3.0.0' dev_dependencies: - test: ^1.2.0 + test: '>=0.12.42 <2.0.0' diff --git a/test/typed_buffers_test.dart b/test/typed_buffers_test.dart index e7633dd..90270fe 100644 --- a/test/typed_buffers_test.dart +++ b/test/typed_buffers_test.dart @@ -265,7 +265,7 @@ testFloat32x4Buffer(List floatSamples) { test("Float32x4Buffer", () { var buffer = new Float32x4Buffer(5); - expect(buffer, TypeMatcher>()); + expect(buffer, new TypeMatcher>()); expect(buffer.length, equals(5)); expect(buffer.elementSizeInBytes, equals(128 ~/ 8)); @@ -312,7 +312,7 @@ void testFloatBuffer( int bitSize, List samples, create(), double round(double v)) { test("Float${bitSize}Buffer", () { var buffer = create(); - expect(buffer, TypeMatcher>()); + expect(buffer, new TypeMatcher>()); int byteSize = bitSize ~/ 8; expect(buffer.length, equals(0)); @@ -380,7 +380,7 @@ void testInt32x4Buffer(List intSamples) { Matcher equals32x4(Int32x4 expected) => new MatchesInt32x4(expected); var buffer = new Int32x4Buffer(0); - expect(buffer, TypeMatcher>()); + expect(buffer, new TypeMatcher>()); expect(buffer.length, equals(0)); expect(buffer.elementSizeInBytes, equals(bytes)); @@ -439,7 +439,7 @@ void testIntBuffer( assert(round(max) == max); // All int buffers default to the value 0. var buffer = create(0); - expect(buffer, TypeMatcher>()); + expect(buffer, new TypeMatcher>()); expect(buffer.length, equals(0)); var bytes = bits ~/ 8;