From d4b69b7bb7b69e4b1f809b3ee3631908ac4103c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=96mer=20Sinan=20A=C4=9Facan?= Date: Tue, 17 Sep 2024 11:39:50 +0200 Subject: [PATCH 1/2] Fix analysis issues --- lib/src/frame.dart | 5 ++++- lib/src/trace.dart | 7 +++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/src/frame.dart b/lib/src/frame.dart index 88670a1..7cd9516 100644 --- a/lib/src/frame.dart +++ b/lib/src/frame.dart @@ -218,9 +218,12 @@ class Frame { /// Parses a Firefox 'eval' or 'function' stack frame. /// - /// for example: + /// For example: + /// + /// ``` /// anonymous/<@https://example.com/stuff.js line 693 > Function:3:40 /// anonymous/<@https://example.com/stuff.js line 693 > eval:3:40 + /// ``` factory Frame._parseFirefoxEval(String frame) => _catchFormatException(frame, () { final match = _firefoxEvalLocation.firstMatch(frame); diff --git a/lib/src/trace.dart b/lib/src/trace.dart index 2e4427d..b133648 100644 --- a/lib/src/trace.dart +++ b/lib/src/trace.dart @@ -32,8 +32,11 @@ final _v8TraceLine = RegExp(r' ?at '); /// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/stack /// /// These stack traces looks like: -/// anonymous/<@https://example.com/stuff.js line 693 > Function:3:40 -/// anonymous/<@https://example.com/stuff.js line 693 > eval:3:40 +/// +/// ```` +/// anonymous/<@https://example.com/stuff.js line 693 > Function:3:40 +/// anonymous/<@https://example.com/stuff.js line 693 > eval:3:40 +/// ```` final _firefoxEvalTrace = RegExp(r'@\S+ line \d+ >.* (Function|eval):\d+:\d+'); /// A RegExp to match Firefox and Safari's stack traces. From 23cf0bbb3dee9e3f53c2165fc701b377e057058e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=96mer=20Sinan=20A=C4=9Facan?= Date: Tue, 17 Sep 2024 11:43:16 +0200 Subject: [PATCH 2/2] Fix typo --- lib/src/trace.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/src/trace.dart b/lib/src/trace.dart index b133648..b8c62f5 100644 --- a/lib/src/trace.dart +++ b/lib/src/trace.dart @@ -31,7 +31,7 @@ final _v8TraceLine = RegExp(r' ?at '); /// /// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/stack /// -/// These stack traces looks like: +/// These stack traces look like: /// /// ```` /// anonymous/<@https://example.com/stuff.js line 693 > Function:3:40