From d823d7cb36922de087a1bd8860303494c21d79c3 Mon Sep 17 00:00:00 2001 From: jrote1 Date: Fri, 22 Aug 2014 10:34:55 +0100 Subject: [PATCH 1/2] Parameterized Test Failure --- test/main.dart | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/test/main.dart b/test/main.dart index 927f84c..73c14de 100644 --- a/test/main.dart +++ b/test/main.dart @@ -37,6 +37,22 @@ class InjectableTest { const InjectableTest(); } +@InjectableTest() +class ParameterizedClass{ + T t; +} + +class GenericArgument{ + +} + +@InjectableTest() +class ClassWithParameterizedDependency{ + ParameterizedClass _parameterizedClass; + + ClassWithParameterizedDependency(this._parameterizedClass); +} + // just some classes for testing @InjectableTest() class Engine { @@ -389,6 +405,16 @@ createInjectorSpec(String injectorName, ModuleFactory moduleFactory) { expect(instance.strs).toEqual(['1', '2']); }); + it('should resolve dependencies with parameterized types using non primitive', () { + var module = moduleFactory() + ..bind(new TypeLiteral>().type, inject: [], toFactory: () => new ParameterizedClass()) + ..bind(ClassWithParameterizedDependency); + var injector = new ModuleInjector([module]); + var instance = injector.get(ClassWithParameterizedDependency); + + expect(instance).toBeAnInstanceOf(ClassWithParameterizedDependency); + }); + it('should resolve dependencies with parameterized types (TypeLiteral)', () { var injector = new ModuleInjector([moduleFactory() ..bind(new TypeLiteral>().type, toValue: {1 : 'first', 2: 'second'}) From b0150d22bf325413e9a49e77deb28ce15a004511 Mon Sep 17 00:00:00 2001 From: jrote1 Date: Fri, 22 Aug 2014 20:45:23 +0100 Subject: [PATCH 2/2] Fixed styling issues --- test/main.dart | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/test/main.dart b/test/main.dart index 73c14de..86e228a 100644 --- a/test/main.dart +++ b/test/main.dart @@ -38,19 +38,19 @@ class InjectableTest { } @InjectableTest() -class ParameterizedClass{ - T t; +class ParameterizedClass { + T t; } -class GenericArgument{ +class GenericArgument { } @InjectableTest() -class ClassWithParameterizedDependency{ - ParameterizedClass _parameterizedClass; +class ClassWithParameterizedDependency { + ParameterizedClass _parameterizedClass; - ClassWithParameterizedDependency(this._parameterizedClass); + ClassWithParameterizedDependency(this._parameterizedClass); } // just some classes for testing @@ -406,14 +406,16 @@ createInjectorSpec(String injectorName, ModuleFactory moduleFactory) { }); it('should resolve dependencies with parameterized types using non primitive', () { - var module = moduleFactory() - ..bind(new TypeLiteral>().type, inject: [], toFactory: () => new ParameterizedClass()) - ..bind(ClassWithParameterizedDependency); - var injector = new ModuleInjector([module]); - var instance = injector.get(ClassWithParameterizedDependency); - - expect(instance).toBeAnInstanceOf(ClassWithParameterizedDependency); - }); + var injector = new ModuleInjector([moduleFactory() + ..bind(new TypeLiteral>().type, + inject: [], + toFactory: () => new ParameterizedClass()) + ..bind(ClassWithParameterizedDependency) + ]); + var instance = injector.get(ClassWithParameterizedDependency); + + expect(instance).toBeAnInstanceOf(ClassWithParameterizedDependency); + }); it('should resolve dependencies with parameterized types (TypeLiteral)', () { var injector = new ModuleInjector([moduleFactory()