really fix new post subscription

Author: dkent600

src/actions/profilesActions.ts

@@ -114,20 +114,33 @@ async function addressForDid(did: string): Promise<Address> {
   return doc.publicKey[2].ethereumAddress;
 }
 
+
+/**
+ * get thread without joining
+ * @param threadName
+ */
+export async function getThread(threadName?: string): Promise<I3BoxThread> {
+  try {
+    await assert3Box();
+    console.info("getting thread");
+    return unauthorizedBox.openThread(spaceName, threadName, {firstModerator: THREEBOXTHREADSMODERATOR, members: false});
+  }
+  catch (ex) {
+    // eslint-disable-next-line no-console
+    console.error(`error getting 3box thread: ${ex}`);
+    return null;
+  }
+}
+
 /**
- * @param thread Optional, if supplied then gets the posts from therre
- * @param threadName Optional, but if no thread, then you must supply threadname
+ * Get the thread posts
+ * @param thread
  */
-export async function getPosts(thread?: I3BoxThread, threadName?: string): Promise<Array<I3BoxThreadPost>> {
+export async function getPosts(thread?: I3BoxThread): Promise<Array<I3BoxThreadPost>> {
   try {
     await assert3Box();
     console.info("getting posts");
-    let posts: Array<I3BoxThreadPost>;
-    if (thread) {
-      posts = (await thread.getPosts()) as Array<I3BoxThreadPost>;
-    } else {
-      posts = (await Box.getThread(spaceName, threadName, THREEBOXTHREADSMODERATOR, false)) as Array<I3BoxThreadPost>;
-    }
+    const posts = (await thread.getPosts()) as Array<I3BoxThreadPost>;
 
     for (const post of posts) {
       post.createDate = moment.unix(post.timestamp);

src/components/Dao/DaoLandingPage.tsx

@@ -9,7 +9,7 @@ import { DiscussionEmbed } from "disqus-react";
 import { formatFriendlyDateForLocalTimezone, showSimpleMessage, targetedNetwork, waitUntilTrue } from "lib/util";
 import customDaoInfo from "../../customDaoInfo";
 import i18next from "i18next";
-import { addPost, getPosts, joinThread, subcribeToThread, threeboxLogin } from "actions/profilesActions";
+import { addPost, getPosts, getThread, joinThread, subcribeToThread, threeboxLogin } from "actions/profilesActions";
 import { connect } from "react-redux";
 import { I3BoxThread, I3BoxThreadPost, IProfilesState } from "reducers/profilesReducer";
 import { IRootState } from "reducers";
@@ -34,6 +34,7 @@ interface IDispatchProps {
 
 interface IExternalStateProps {
   profiles: IProfilesState;
+  threeBox: any;
 }
 
 interface IStateProps {
@@ -52,6 +53,7 @@ const mapStateToProps = (state: IRootState, ownProps: IExternalProps): IExternal
   return {
     ...ownProps,
     profiles: state.profiles,
+    threeBox: state.profiles.threeBox,
   };
 };
 
@@ -74,12 +76,16 @@ class DaoLandingPage extends React.Component<IProps, IStateProps> {
   }
 
 
-  private get3BoxThread(): Promise<I3BoxThread | null> {
-    return joinThread(this.props.daoState.id, this.props.currentAccountAddress, this.props.profiles);
+  private get3BoxThread(join = false): Promise<I3BoxThread | null> {
+    if (join) {
+      return joinThread(this.props.daoState.id, this.props.currentAccountAddress, this.props.profiles);
+    } else {
+      return getThread(this.props.daoState.id);
+    }
   }
 
-  private getPosts = async (thread?: I3BoxThread) => {
-    return (await getPosts(thread, this.props.daoState.id)).sort((a, b) =>
+  private getPosts = async (thread: I3BoxThread) => {
+    return (await getPosts(thread)).sort((a, b) =>
     { return SortService.evaluateDateTime(a.createDate, b.createDate, SortOrder.DESC); });
   }
 
@@ -90,18 +96,19 @@ class DaoLandingPage extends React.Component<IProps, IStateProps> {
       "DAO Name": this.props.daoState.name,
     });
 
-    const state: Partial<IStateProps> = {};
     const thread = await this.get3BoxThread();
     if (thread) {
-      subcribeToThread(thread, this.handleNewPosts);
-      state.joinedThread = thread;
+      // subcribeToThread(thread, this.handleNewPosts);
+      const posts = await this.getPosts(thread);
+      this.setState({ threeboxPosts: posts });
     }
-    const posts = await this.getPosts(thread);
-    state.threeboxPosts = posts;
+  }
 
-    this.setState(state);
+  componentWillUnmount() {
+    this.setState({ threeboxPosts: null, joinedThread: null, hasCommentInput: false, joiningThread: false });
   }
 
+
   private handleNewPosts = async () => {
     const posts = await this.getPosts(this.state.joinedThread);
     this.setState({ threeboxPosts: posts });
@@ -133,10 +140,10 @@ class DaoLandingPage extends React.Component<IProps, IStateProps> {
           await waitUntilTrue(() => !!this.props.currentAccountAddress && getAccountIsEnabled(), 15000);
           await this.props.threeboxLogin(this.props.currentAccountAddress);
           await waitUntilTrue(() => !!this.props.profiles.threeBoxSpace, 30000);
-          const thread = await this.get3BoxThread();
+          const thread = await this.get3BoxThread(true);
           if (thread) {
             subcribeToThread(thread, this.handleNewPosts);
-            this.setState({ joinedThread: thread });
+            this.setState({ joinedThread: thread }); // so we can see our new posts when we post them
           } else {
             showNotification(NotificationStatus.Failure, "Unable to join the conversation");
           }