Skip to content

Commit 7560925

Browse files
jmagmandanilozhang
authored andcommitted
Suppress deprecated iOS windows API in integration_test (flutter#173251)
Suppress the scene deprecation warning to unblock iOS 15+ deprecation checks in the packages repo: flutter/packages#7542 Not really part of flutter#170171, but related problem. Tracking issue: flutter#154365 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 94960d6 commit 7560925

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

packages/integration_test/ios/integration_test/Sources/integration_test/IntegrationTestPlugin.m

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,12 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
7979

8080
- (UIImage *)capturePngScreenshot {
8181
// Get all windows in the app
82+
#pragma clang diagnostic push
83+
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
84+
// TODO(jmagman) Use scenes instead of deprecated windows. See
85+
// https://github.com/flutter/flutter/issues/154365
8286
NSArray<UIWindow *> *windows = [UIApplication sharedApplication].windows;
87+
#pragma clang diagnostic pop
8388

8489
// Find the overall bounding rect for all windows
8590
CGRect screenBounds = [UIScreen mainScreen].bounds;

0 commit comments

Comments
 (0)