Merge branch 'v11' into content/remove-obsolete-for-multidomain-ga

Author: mjhenkes

content/_changelogs/11.0.0.md

@@ -0,0 +1,13 @@
+## 11.0.0
+
+_Released MM/DD/YYYY_
+
+**Breaking Changes:**
+
+- `experimentalSessionAndOrigin` flag has been removed and all functionality is
+  on by default now.
+- `testIsolation` defaults to `strict` now.
+- `Cookies.defaults` and `Cookies.preserveOnce` have been removed. Please update
+  to use [`cy.session()`](/api/commands/session) to preserve session details
+  between tests. Addresses
+  [#21472](https://github.com/cypress-io/cypress/issues/21472).

content/api/commands/origin.md

@@ -13,37 +13,6 @@ limitation determined by standard web security features of the browser. The
 
 <Alert type="warning">
 
-<strong class="alert-header"><Icon name="exclamation-triangle"></Icon>
-Experimental</strong>
-
-The `cy.origin()` command is currently experimental and can be enabled by
-setting
-the [`experimentalSessionAndOrigin`](/guides/references/experiments) flag
-to `true` in the Cypress config.
-
-Enabling this flag does the following:
-
-- It adds the [`cy.session()`](/api/commands/session) and `cy.origin()`
-  commands, and [`Cypress.session`](/api/cypress-api/session) API.
-- It adds the following new behaviors (that will be the default in a future
-  major version release of Cypress) at the beginning of each test:
-  - The page is cleared (by setting it to `about:blank`).
-  - All active session data (cookies, `localStorage` and `sessionStorage`)
-    across all domains are cleared.
-- It supersedes
-  the [`Cypress.Cookies.preserveOnce()`](/api/cypress-api/cookies#Preserve-Once) and
-  [`Cypress.Cookies.defaults()`](/api/cypress-api/cookies#Defaults) methods.
-- Cross-origin requests will now succeed, however, to interact with a
-  cross-origin page you must use a `cy.origin` block.
-
-Because the page is cleared before each
-test, [`cy.visit()`](/api/commands/visit) must be explicitly called in each test
-to visit a page in your application.
-
-</Alert>
-
-<Alert type="warning">
-
 <strong class="alert-header"><Icon name="exclamation-triangle"></Icon>
 Obstructive Third Party Code</strong>
 
@@ -341,9 +310,8 @@ performant. Up until now you could get around this problem by putting login code
 in the first test of your file, then performing subsequent tests reusing the
 same session.
 
-However, once the `experimentalSessionAndOrigin` flag is activated, this is no
-longer possible, since all session state is now cleared between tests. So to
-avoid this overhead we recommend you leverage the
+However, this is no longer possible, since all session state is now cleared
+between tests. So to avoid this overhead we recommend you leverage the
 [`cy.session()`](/api/commands/session) command, which allows you to easily
 cache session information and reuse it across tests. So now let's enhance our
 custom login command with `cy.session()` for a complete syndicated login flow
@@ -386,81 +354,6 @@ and reuse it across tests.
 
 ## Notes
 
-### Migrating existing tests
-
-Enabling the `experimentalSessionAndOrigin` flag makes the test-runner work
-slightly differently, and some test suites that rely on the existing behaviour
-may have to be updated. The most important of these changes is **test
-isolation**. This means that after every test, the current page is reset to
-`about:blank` and all active session data
-(cookies, `localStorage` and `sessionStorage`) across all domains are cleared.
-This change is opt-in for now, but will be standardized in a future major
-release of Cypress, so eventually all tests will need to be isolated.
-
-Before this change, it was possible to write tests such that you could, for
-example, log in to a CMS in the first test, change some content in the second
-test, verify the new version is displayed on a different URL in the third, and
-log out in the fourth. Here's a simplified example of such a test strategy.
-
-<Badge type="danger">Before</Badge> Multiple small tests against different
-origins
-
-```js
-it('logs in', () => {
-  cy.visit('https://supersecurelogons.com')
-  cy.get('input#password').type('Password123!')
-  cy.get('button#submit').click()
-})
-
-it('updates the content', () => {
-  cy.get('#current-user').contains('logged in')
-  cy.get('button#edit-1').click()
-  cy.get('input#title').type('Updated title')
-  cy.get('button#submit').click()
-  cy.get('.toast').type('Changes saved!')
-})
-
-it('validates the change', () => {
-  cy.visit('/items/1')
-  cy.get('h1').contains('Updated title')
-})
-```
-
-After switching on `experimentalSessionAndOrigin`, this flow would need to be
-contained within a single test. While this practice has always been
-[discouraged](/guides/references/best-practices#Having-tests-rely-on-the-state-of-previous-tests)
-we know some users have historically written tests this way, often to get around
-the same-origin restrictions. But with `cy.origin()` you no longer need these
-kind of brittle hacks, as your multi-origin logic can all reside in a single
-test, like the following.
-
-<Badge type="success">After</Badge> One big test using `cy.origin()`
-
-```js
-it('securely edits content', () => {
-  cy.origin('supersecurelogons.com', () => {
-    cy.visit('https://supersecurelogons.com')
-    cy.get('input#password').type('Password123!')
-    cy.get('button#submit').click()
-  })
-
-  cy.origin('mycms.com', () => {
-    cy.url().should('contain', 'cms')
-    cy.get('#current-user').contains('logged in')
-    cy.get('button#edit-1').click()
-    cy.get('input#title').type('Updated title')
-    cy.get('button#submit').click()
-    cy.get('.toast').type('Changes saved!')
-  })
-
-  cy.visit('/items/1')
-  cy.get('h1').contains('Updated title')
-})
-```
-
-Always remember,
-[Cypress tests are not unit tests](https://docs.cypress.io/guides/references/best-practices#Creating-tiny-tests-with-a-single-assertion).
-
 ### Serialization
 
 When entering a `cy.origin()` block, Cypress injects itself at runtime, with all
@@ -615,7 +508,6 @@ following Cypress commands will throw errors if used in the callback:
 - `cy.origin()`
 - [`cy.intercept()`](/api/commands/intercept)
 - [`cy.session()`](/api/commands/session)
-- [`Cypress.Cookies.preserveOnce()`](/api/cypress-api/cookies)
 
 ### Other limitations
 

content/api/commands/session.md

@@ -9,39 +9,6 @@ and
 [`sessionStorage`](https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage)
 in order to reduce test setup times.
 
-<Alert type="warning">
-
-<strong class="alert-header"><Icon name="exclamation-triangle"></Icon>
-Experimental</strong>
-
-The `session` API is currently experimental, and can be enabled by setting the
-[`experimentalSessionAndOrigin`](/guides/references/experiments) option to
-`true` in the Cypress config.
-
-Enabling this flag does the following:
-
-- It adds the `cy.session()` and [`cy.origin()`](/api/commands/origin) commands,
-  and [`Cypress.session`](/api/cypress-api/session) API.
-- It adds the following new behaviors (that will be the default in a future
-  major update of Cypress) at the beginning of each test:
-  - The page is cleared (by setting it to `about:blank`). Disable this by
-    setting
-    [`testIsolation=legacy`](/guides/core-concepts/writing-and-organizing-tests#Test-Isolation).
-  - All active session data (cookies, `localStorage` and `sessionStorage`)
-    across all domains are cleared.
-- It overrides the
-  [`Cypress.Cookies.preserveOnce()`](/api/cypress-api/cookies#Preserve-Once) and
-  [`Cypress.Cookies.defaults()`](/api/cypress-api/cookies#Defaults) methods.
-- Cross-origin navigation will no longer fail immediately, but instead, time out
-  based on [`pageLoadTimeout`](/guides/references/configuration#Timeouts).
-- Tests will no longer wait on page loads before moving on to the next test.
-
-Because the page is cleared at the beginning of each test,
-[`cy.visit()`](/api/commands/visit) must be explicitly called at the beginning
-of each test.
-
-</Alert>
-
 ## Syntax
 
 ```javascript

content/api/commands/should.md

@@ -172,6 +172,35 @@ Be sure _not_ to include any code that has side effects in your callback
 function. The callback function will be retried over and over again until no
 assertions within it throw.
 
+You cannot invoke Cypress commands inside of a `.should()` callback function.
+Use Cypress commands before or after `.should()` instead.
+
+**<Icon name="exclamation-triangle" color="red"></Icon> Incorrect Usage**
+
+```javascript
+cy.get('p').should(($p) => {
+  cy.log($p)
+  // ...
+})
+```
+
+**<Icon name="check-circle" color="green"></Icon> Correct Usage**
+
+```javascript
+cy.get('p')
+  .should(($p) => {
+    // ...
+  })
+  .log()
+
+// or
+
+cy.get('p').then(($p) => {
+  // ...
+  cy.log($p)
+})
+```
+
 #### Verify length, content, and classes from multiple `<p>`
 
 ```html
@@ -467,10 +496,11 @@ following:
 
 ## History
 
-| Version                                       | Changes                           |
-| --------------------------------------------- | --------------------------------- |
-| [0.11.4](/guides/references/changelog#0-11-4) | Allows callback function argument |
-| [< 0.3.3](/guides/references/changelog#0-3-3) | `.should()` command added         |
+| Version                                       | Changes                                         |
+| --------------------------------------------- | ----------------------------------------------- |
+| [11.0.0](/guides/references/changelog#11-0-0) | Throw error if Cypress command used in callback |
+| [0.11.4](/guides/references/changelog#0-11-4) | Allows callback function argument               |
+| [< 0.3.3](/guides/references/changelog#0-3-3) | `.should()` command added                       |
 
 ## See also
 

content/api/commands/visit.md

@@ -415,23 +415,12 @@ pass.</li></List>
 
 ## Visiting cross-origin sites
 
-<Alert type="warning">
-
-<strong class="alert-header"><Icon name="exclamation-triangle"></Icon>
-Experimental</strong>
-
-Visiting cross-origin sites will currently throw an error. It can be enabled by
-setting
-the [`experimentalSessionAndOrigin`](/guides/references/experiments) flag
-to `true` in the Cypress config. This will allow you to visit the cross-origin
-site without errors. However, to interact with the content on the cross-origin
-site, you must use a [`cy.origin()`](/api/commands/origin) block.
+After visiting a cross-origin site, to interact with the content, you must use a
+[`cy.origin()`](/api/commands/origin) block.
 
 When visiting a cross-origin site, the `onBeforeLoad` and `onLoad` options are
 not supported.
 
-</Alert>
-
 ## Command Log
 
 **_Visit example application in a `beforeEach`_**
@@ -455,6 +444,7 @@ following:
 
 | Version                                       | Changes                                                                          |
 | --------------------------------------------- | -------------------------------------------------------------------------------- |
+| [11.0.0](/guides/references/changelog#11-0-0) | Removed `experimentalSessionAndOrigin` reference                                 |
 | [3.5.0](/guides/references/changelog#3-5-0)   | Added support for options `qs`                                                   |
 | [3.3.0](/guides/references/changelog#3-3-0)   | Added support for options `retryOnStatusCodeFailure` and `retryOnNetworkFailure` |
 | [3.2.0](/guides/references/changelog#3-2-0)   | Added options `url`, `method`, `body`, and `headers`                             |