Skip to content

Commit f93486a

Browse files
can: mcp251xfd: unify error messages and commets
This patch unifies the error messages: - have a "." and the end of each message - write controller with a small "c", if not the first word of an error message. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Marc Kleine-Budde <[email protected]>
1 parent 9f1fbc1 commit f93486a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -651,7 +651,7 @@ static int mcp251xfd_chip_softreset_check(const struct mcp251xfd_priv *priv)
651651

652652
if (osc != osc_reference) {
653653
netdev_info(priv->ndev,
654-
"Controller failed to reset. osc=0x%08x, reference value=0x%08x\n",
654+
"Controller failed to reset. osc=0x%08x, reference value=0x%08x.\n",
655655
osc, osc_reference);
656656
return -ETIMEDOUT;
657657
}
@@ -666,7 +666,7 @@ static int mcp251xfd_chip_softreset(const struct mcp251xfd_priv *priv)
666666
for (i = 0; i < MCP251XFD_SOFTRESET_RETRIES_MAX; i++) {
667667
if (i)
668668
netdev_info(priv->ndev,
669-
"Retrying to reset Controller.\n");
669+
"Retrying to reset controller.\n");
670670

671671
err = mcp251xfd_chip_softreset_do(priv);
672672
if (err == -ETIMEDOUT)
@@ -1239,7 +1239,7 @@ mcp251xfd_handle_tefif_recover(const struct mcp251xfd_priv *priv, const u32 seq)
12391239
}
12401240

12411241
netdev_info(priv->ndev,
1242-
"Transmit Event FIFO buffer %s. (seq=0x%08x, tef_tail=0x%08x, tef_head=0x%08x, tx_head=0x%08x)\n",
1242+
"Transmit Event FIFO buffer %s. (seq=0x%08x, tef_tail=0x%08x, tef_head=0x%08x, tx_head=0x%08x).\n",
12431243
tef_sta & MCP251XFD_REG_TEFSTA_TEFFIF ?
12441244
"full" : tef_sta & MCP251XFD_REG_TEFSTA_TEFNEIF ?
12451245
"not empty" : "empty",
@@ -1891,7 +1891,7 @@ mcp251xfd_handle_modif(const struct mcp251xfd_priv *priv, bool *set_normal_mode)
18911891
"Controller changed into %s Mode (%u).\n",
18921892
mcp251xfd_get_mode_str(mode), mode);
18931893

1894-
/* After the application requests Normal mode, the Controller
1894+
/* After the application requests Normal mode, the controller
18951895
* will automatically attempt to retransmit the message that
18961896
* caused the TX MAB underflow.
18971897
*

0 commit comments

Comments
 (0)