Skip to content

Commit f6e2c20

Browse files
Liu Shixinakpm00
authored andcommitted
fs: sysv: check sbi->s_firstdatazone in complete_read_super
sbi->s_firstinodezone is initialized to 2 and sbi->s_firstdatazone is read from sbd. There's no guarantee that sbi->s_firstdatazone must bigger than sbi->s_firstinodezone. If sbi->s_firstdatazone less than 2, the filesystem can still be mounted unexpetly. At this point, sbi->s_ninodes flip to very large value and this filesystem is broken. We can observe this by executing 'df' command. When we execute, we will get an error message: "sysv_count_free_inodes: unable to read inode table" Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Liu Shixin <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent edc73c7 commit f6e2c20

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

fs/sysv/super.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,9 @@ static int complete_read_super(struct super_block *sb, int silent, int size)
312312
sbi->s_firstinodezone = 2;
313313

314314
flavour_setup[sbi->s_type](sbi, &sb->s_max_links);
315-
315+
if (sbi->s_firstdatazone < sbi->s_firstinodezone)
316+
return 0;
317+
316318
sbi->s_ndatazones = sbi->s_nzones - sbi->s_firstdatazone;
317319
sbi->s_inodes_per_block = bsize >> 6;
318320
sbi->s_inodes_per_block_1 = (bsize >> 6)-1;

0 commit comments

Comments
 (0)