Skip to content

Commit f6a69a8

Browse files
Mahesh Bandewardavem330
authored andcommitted
bonding: Fix another case of LACPDU not sent on slave
When mii-mon discovers that the link is up, it will call bond_3ad_handle_link_change() but we forget to add the LACP_ENABLED flag when we discover the speed and duplex for the slave link are normal. Change-Id: Ie8b268ecfeea0f99bf9fdcd72706c0653f9d9e49 Signed-off-by: Mahesh Bandewar <[email protected]> Signed-off-by: Andy Gospodarek <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent ef015d7 commit f6a69a8

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/net/bonding/bond_3ad.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2415,12 +2415,15 @@ void bond_3ad_handle_link_change(struct slave *slave, char link)
24152415
port->actor_admin_port_key &= ~AD_SPEED_KEY_MASKS;
24162416
port->actor_oper_port_key = port->actor_admin_port_key |=
24172417
(__get_link_speed(port) << 1);
2418+
if (port->actor_oper_port_key & AD_DUPLEX_KEY_MASKS)
2419+
port->sm_vars |= AD_PORT_LACP_ENABLED;
24182420
} else {
24192421
/* link has failed */
24202422
port->is_enabled = false;
24212423
port->actor_admin_port_key &= ~AD_DUPLEX_KEY_MASKS;
24222424
port->actor_oper_port_key = (port->actor_admin_port_key &=
24232425
~AD_SPEED_KEY_MASKS);
2426+
port->sm_vars &= ~AD_PORT_LACP_ENABLED;
24242427
}
24252428
netdev_dbg(slave->bond->dev, "Port %d changed link status to %s\n",
24262429
port->actor_port_number,

0 commit comments

Comments
 (0)