Skip to content

Commit f6663a9

Browse files
committed
Merge tag 'w1-drv-6.11' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/krzk/linux-w1 into char-misc-next
Krzysztof writes: 1-Wire bus drivers for v6.11 Just two cleanups for W1 core code. * tag 'w1-drv-6.11' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/krzk/linux-w1: w1: Drop allocation error message w1: Add missing newline and fix typos in w1_bus_master comment
2 parents e78c87b + 26bf5fc commit f6663a9

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

drivers/w1/w1.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,7 @@ static ssize_t w1_master_attribute_store_remove(struct device *dev,
504504
if (result == 0)
505505
result = count;
506506
} else {
507-
dev_info(dev, "Device %02x-%012llx doesn't exists\n", rn.family,
507+
dev_info(dev, "Device %02x-%012llx doesn't exist\n", rn.family,
508508
(unsigned long long)rn.id);
509509
result = -EINVAL;
510510
}

drivers/w1/w1_int.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,8 @@ static struct w1_master *w1_alloc_dev(u32 id, int slave_count, int slave_ttl,
3232
* We are in process context(kernel thread), so can sleep.
3333
*/
3434
dev = kzalloc(sizeof(struct w1_master) + sizeof(struct w1_bus_master), GFP_KERNEL);
35-
if (!dev) {
36-
pr_err("Failed to allocate %zd bytes for new w1 device.\n",
37-
sizeof(struct w1_master));
35+
if (!dev)
3836
return NULL;
39-
}
40-
4137

4238
dev->bus_master = (struct w1_bus_master *)(dev + 1);
4339

include/linux/w1.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ typedef void (*w1_slave_found_callback)(struct w1_master *, u64);
8585
*
8686
* @data: the first parameter in all the functions below
8787
*
88-
* @read_bit: Sample the line level @return the level read (0 or 1)
88+
* @read_bit: Sample the line level
89+
* @return the level read (0 or 1)
8990
*
9091
* @write_bit: Sets the line level
9192
*
@@ -95,7 +96,7 @@ typedef void (*w1_slave_found_callback)(struct w1_master *, u64);
9596
* touch_bit(1) = write-1 / read cycle
9697
* @return the bit read (0 or 1)
9798
*
98-
* @read_byte: Reads a bytes. Same as 8 touch_bit(1) calls.
99+
* @read_byte: Reads a byte. Same as 8 touch_bit(1) calls.
99100
* @return the byte read
100101
*
101102
* @write_byte: Writes a byte. Same as 8 touch_bit(x) calls.
@@ -114,7 +115,7 @@ typedef void (*w1_slave_found_callback)(struct w1_master *, u64);
114115
* @set_pullup: Put out a strong pull-up pulse of the specified duration.
115116
* @return -1=Error, 0=completed
116117
*
117-
* @search: Really nice hardware can handles the different types of ROM search
118+
* @search: Really nice hardware can handle the different types of ROM search
118119
* w1_master* is passed to the slave found callback.
119120
* u8 is search_type, W1_SEARCH or W1_ALARM_SEARCH
120121
*

0 commit comments

Comments
 (0)